chore: update biome configurations and applied settings#2931
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2931 +/- ##
==========================================
- Coverage 94.39% 94.38% -0.01%
==========================================
Files 44 44
Lines 7861 7857 -4
Branches 699 699
==========================================
- Hits 7420 7416 -4
Misses 435 435
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
left a comment
There was a problem hiding this comment.
@theorderingmachine LGTM! Lots of reorderings of imports but this is a good change I think.
📚 https://biomejs.dev/guides/upgrade-to-biome-v2/
Will merge this with tests passing and research in comments to unblock #2854.
| "overrides": [ | ||
| { | ||
| "includes": ["examples/**"], | ||
| "linter": { | ||
| "rules": { | ||
| "correctness": { | ||
| "noUnusedFunctionParameters": "off", | ||
| "noUnusedVariables": "off" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ], |
There was a problem hiding this comment.
📚 note: Our examples use handfuls of unused variables with intention so we ignore some rule for now to avoid more changes:
bolt-js/examples/socket-mode/app.js
Lines 59 to 63 in c8de330
| throw new AppInitializationError( | ||
| `${tokenUsage} \n\nSince you have not provided a token or authorize, you might be missing one or more required oauth installer options. See https://docs.slack.dev/tools/bolt-js/concepts/authenticating-oauth/ for these required fields.\n`, | ||
| ); | ||
| // biome-ignore lint/style/noUselessElse: I think this is a biome issue actually... |
There was a problem hiding this comment.
🔭 note: We might be confident in these reorderings with the following reference:
If there are two wildcard exports statements that implicitly re-export the same name, neither one is re-exported.
Summary
Validation
Notes: