Skip to content

chore: update biome configurations and applied settings#2931

Merged
zimeg merged 6 commits into
slackapi:mainfrom
theorderingmachine:chore/migrate-biome-v2
May 15, 2026
Merged

chore: update biome configurations and applied settings#2931
zimeg merged 6 commits into
slackapi:mainfrom
theorderingmachine:chore/migrate-biome-v2

Conversation

@theorderingmachine
Copy link
Copy Markdown
Contributor

Summary

  • upgrade @biomejs/biome to the current v2 line
  • migrate biome.json to Biome 2 config format
  • apply Biome 2 formatting / organize-imports changes across source, tests, and examples
  • clean up a few newly-flagged example-code and suppression warnings so Biome 2 passes cleanly

Validation

  • biome check docs src test examples
  • npm run build
  • npm run test:types
  • npm run test:coverage

Notes:

  • On this NixOS host, npm run lint still tries to execute the vendored Biome binary from node_modules, which is dynamically linked and not runnable here.
  • Validation was done with nixpkgs#biome for the lint-equivalent check instead.

@theorderingmachine theorderingmachine requested a review from a team as a code owner May 15, 2026 01:29
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 15, 2026

⚠️ No Changeset found

Latest commit: 0ea3a5b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zimeg zimeg added semver:patch dependencies Pull requests that update a dependency file labels May 15, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.38%. Comparing base (c8de330) to head (0ea3a5b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2931      +/-   ##
==========================================
- Coverage   94.39%   94.38%   -0.01%     
==========================================
  Files          44       44              
  Lines        7861     7857       -4     
  Branches      699      699              
==========================================
- Hits         7420     7416       -4     
  Misses        435      435              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zimeg zimeg added this to the @slack/bolt@next milestone May 15, 2026
Copy link
Copy Markdown
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theorderingmachine LGTM! Lots of reorderings of imports but this is a good change I think.

📚 https://biomejs.dev/guides/upgrade-to-biome-v2/

Will merge this with tests passing and research in comments to unblock #2854.

Comment thread biome.json
Comment on lines +34 to +46
"overrides": [
{
"includes": ["examples/**"],
"linter": {
"rules": {
"correctness": {
"noUnusedFunctionParameters": "off",
"noUnusedVariables": "off"
}
}
}
}
],
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📚 note: Our examples use handfuls of unused variables with intention so we ignore some rule for now to avoid more changes:

// Message Shortcut example
app.shortcut('launch_msg_shortcut', async ({ shortcut, body, ack, context, client, logger }) => {
await ack();
logger.info(shortcut);
});

Comment thread src/App.ts
throw new AppInitializationError(
`${tokenUsage} \n\nSince you have not provided a token or authorize, you might be missing one or more required oauth installer options. See https://docs.slack.dev/tools/bolt-js/concepts/authenticating-oauth/ for these required fields.\n`,
);
// biome-ignore lint/style/noUselessElse: I think this is a biome issue actually...
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌲 praise: Thanks latest update!

Comment thread src/types/index.ts
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔭 note: We might be confident in these reorderings with the following reference:

If there are two wildcard exports statements that implicitly re-export the same name, neither one is re-exported.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/export#re-exporting_aggregating

@zimeg zimeg changed the title chore: migrate biome to v2 chore: update biome configurations and applied settings May 15, 2026
@zimeg zimeg self-assigned this May 15, 2026
@zimeg zimeg merged commit be24571 into slackapi:main May 15, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:signed dependencies Pull requests that update a dependency file semver:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants