feat: icon field#62
Closed
srtaalej wants to merge 2 commits into
Closed
Conversation
zimeg
requested changes
Apr 24, 2026
Author
ah you're right it should be at the top level 😨 |
Author
|
closing this - we are approaching Icon support in the root of apps instead ⭐ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add icon field to both
v1andv2manifest schemas to supportapps.icon.setfunctionality (see slackapi/slack-cli#469). The field is an optional string containing a path to the app's icon image file.Testing
Category
manifest.schema.jsonedit/schemaand/or its core componentsRequirements
./scripts/install_all_and_run_tests.shafter making the changes.