feat: add optional scopes to oauth_config schema#64
Conversation
mwbrooks
left a comment
mwbrooks
left a comment
There was a problem hiding this comment.
Comments for the kind reviewers
| # Create and activate a virtual environment (first time only) | ||
| python -m venv .venv | ||
| source .venv/bin/activate | ||
|
|
| ```bash | ||
| source .venv/bin/activate | ||
| pip install -U -e . | ||
| ``` |
| }, | ||
| "maxItems": 255 | ||
| }, | ||
| "user_optional": { |
There was a problem hiding this comment.
📚 suggestion(non-blocking): Let's add the description to version 1 as well? I find this format is used often in existing apps. No blocker because I realize this might be a pattern throughout this file!
An array of strings containing optional user scopes. Optional scopes must also be listed in the corresponding user fields.
There was a problem hiding this comment.
@zimeg Can we look at this in a different PR? There are no descriptions in version 1 format and I'm unsure why or what side effects happen if we add the description field.
There was a problem hiding this comment.
@mwbrooks Of course! I understand this might've been generated too and changing it too much can make later understandings confused.
|
Thanks for the quick reviews @zimeg! 🙇🏻 |
2 participants
Summary
This pull request adds
user_optionalandbot_optionalscope arrays to theoauth_config.scopesschema definition in both v1 and v2 manifest schemas.Also updates development documentation to recommend using a
.venvvirtual environment.Testing
user_optionalandbot_optionalproperties appear underoauth_config.scopesin bothschemas/manifest.schema.1.0.0.jsonandschemas/manifest.schema.2.0.0.jsonuserandbot(string items, maxLength 50, maxItems 255)Category
manifest.schema.jsonedit/schemaand/or its core componentsRequirements
./scripts/install_all_and_run_tests.shafter making the changes.