feat: add chip-ingress batch config keys to TOML and wire through#22987
Merged
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
pkcll
force-pushed
the
chip-ingress-batch-config
branch
2 times, most recently
from
June 29, 2026 22:10
e3ae0d9 to
15564d4
Compare
pkcll
force-pushed
the
chip-ingress-batch-config
branch
from
July 21, 2026 05:44
6762cf4 to
4296b81
Compare
Add 7 chip-ingress batch configuration keys to the [Telemetry] TOML config and wire them through the host and LOOP plugin paths. Default changes: - ChipIngressBufferSize: 1000 -> 10000 - ChipIngressMaxBatchSize: 500 -> 1000 - ChipIngressSendInterval: 100ms -> 500ms - ChipIngressSendTimeout: 3s -> 10s - ChipIngressDrainTimeout: 10s -> 30s Update core/config/docs/core.toml, docs/CONFIG.md, and all golden validation fixtures to match the new chainlink-common defaults. Add a changeset and bump chainlink-common to the latest chip-ingress-batch-config PR commit (caf610156) to pick up the beholder.Config changes.
pkcll
force-pushed
the
chip-ingress-batch-config
branch
from
July 21, 2026 05:49
4296b81 to
faebc98
Compare
pkcll
marked this pull request as ready for review
July 21, 2026 05:50
product-security-plaid-production
Bot
requested review from
pavel-raykov and
skudasov
July 21, 2026 05:50
pkcll
force-pushed
the
chip-ingress-batch-config
branch
from
July 21, 2026 21:26
800c6d5 to
4270694
Compare
pkcll
enabled auto-merge
July 22, 2026 15:17
pavel-raykov
previously approved these changes
Jul 22, 2026
jmank88
reviewed
Jul 22, 2026
Comment on lines
-670
to
-672
| // Exclude Juno's placeholder dependency. It is only intended to be resolved via | ||
| // Juno's local replace directive and is not used directly by chainlink | ||
| exclude github.com/starknet-io/starknet-p2pspecs v0.0.0-00010101000000-000000000000 |
jmank88
approved these changes
Jul 22, 2026
pavel-raykov
approved these changes
Jul 22, 2026
|
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add 7 chip-ingress batch configuration keys to the
[Telemetry]TOML config, wire them through the host and LOOP plugin paths, and align the chainlink defaults with the chainlink-commonbeholder.DefaultConfig()bumps.Depends on
Default changes
Changes
core/config/toml/types.go: 7 fields onTelemetrystruct +setFromcore/config/telemetry_config.go: 7 accessorscore/services/chainlink/config_telemetry.go: pass-through implementationscore/cmd/shell.go: host wiring tobeholder.Configplugins/loop_registry.go: LOOP wiring toloop.EnvConfigcore/config/docs/core.toml+docs/CONFIG.md: documented defaultsTesting
go test ./core/config/... ./core/services/chainlink/... ./plugins/... ./core/cmd/...make config-docsNotes
Telemetry.ValidateConfig().