Skip to content

bump chainlink-common for chip-ingress resource attributes#23014

Draft
pkcll wants to merge 7 commits into
developfrom
chip-ingress-resource-attributes
Draft

bump chainlink-common for chip-ingress resource attributes#23014
pkcll wants to merge 7 commits into
developfrom
chip-ingress-resource-attributes

Conversation

@pkcll

@pkcll pkcll commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Bumps chainlink-common and pkg/chipingress to the resource-attributes work in smartcontractkit/chainlink-common#2216 (which depends on smartcontractkit/chainlink-common#2267 for the ChipIngress client API).
  • No chainlink application code changes required: core/cmd/shell.go already maps TOML resource attributes into beholder.Config.ResourceAttributes, and plugins/loop_registry.go already passes TelemetryAttributes to LOOP plugins.

Depends on

  1. Upstream (chipingress client): Add resource attribute support to ChipIngress client chainlink-common#2267
  2. Upstream (beholder wiring): Wire resource attributes into Beholder ChipIngress emitters chainlink-common#2216

Related PRs

Pinned versions

  • github.com/smartcontractkit/chainlink-commonv0.11.2-0.20260721063811-fccea7a53c53
  • github.com/smartcontractkit/chainlink-common/pkg/chipingressv0.0.11-0.20260721062847-690c417fc953

Known gap (from common PRs)

pkg/durableemitter is out of scope. Events emitted via durableemitter.GlobalEmit (workflows, capabilities) will not yet carry resource attributes on the cre topic. Follow-up work is tracked separately.

Test plan

  • go test ./core/cmd/... ./core/services/chainlink/... ./plugins/... -short
  • Manual: deploy with custom [Telemetry.ResourceAttributes], emit a platform event, verify ce_<sanitized> headers on cre

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@pkcll
pkcll force-pushed the chip-ingress-resource-attributes branch 3 times, most recently from 9a1d9ef to 0a62cd0 Compare July 11, 2026 01:30
@trunk-io

trunk-io Bot commented Jul 11, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@pkcll
pkcll force-pushed the chip-ingress-resource-attributes branch from 98ad2d2 to 69956da Compare July 21, 2026 06:39
@pkcll
pkcll force-pushed the chip-ingress-resource-attributes branch from d32370d to a7f49c0 Compare July 22, 2026 05:42
@cl-sonarqube-production

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant