chore: update error handling for permission denied cases and bump crec-api-go dependency to v0.8.0-rc2 - #190
Open
lucasfleischer7 wants to merge 2 commits into
Open
chore: update error handling for permission denied cases and bump crec-api-go dependency to v0.8.0-rc2#190lucasfleischer7 wants to merge 2 commits into
lucasfleischer7 wants to merge 2 commits into
Conversation
…c-api-go dependency to v0.8.0-rc2
|
👋 lucasfleischer7, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
masha256
requested changes
Aug 13, 2026
masha256
left a comment
masha256
left a comment
Collaborator
There was a problem hiding this comment.
That is a lot of repeated handling of errors that all look the same. Should we have a generic error helper that handles the common case logic and only break it out when there is non-standard error handling?
masha256
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.