Add keepers example using function selector checkData

[giovannidisiena]

This PR extends the KeepersCounter.sol contract to add example usage of function selectors as checkData.

Tested locally and on Kovan testnet using Upkeep IDs [2028, 2029, 2030].

Corresponding tests will skip if multiplierEnabled is set to "false" in helper-hardhat-config.js.

[PatrickAlphaC]

Ooohhhh. I like the idea of using an example with a perforumData. @andrejrakic can you take a look?

[PatrickAlphaC]

Ahhh, sorry @giovannidisiena. Want to update this and we'll give it a proper look?

[PatrickAlphaC]

Wait.... How did @rdotterer09 approve the PR?

[giovannidisiena]

Ahhh, sorry @giovannidisiena. Want to update this and we'll give it a proper look?

Not a problem @PatrickAlphaC, likewise apologies for the delay. Assume you just mean to update by rebase and resolve conflicts right?

Wait.... How did @rdotterer09 approve the PR?

Lol no idea

[rdotterer09]

Guys, I'm not a coder, or trader, just an investor, I'm slowly learning how to read this code business so I am no threat to you, please update me on the total I have in contract after conversion is completed, Thank You

[rdotterer09]

Is important for you guys to know I have some of the contract addresses on two different hard wallets, some on Arculus and some on nano X

[PatrickAlphaC]

@rdotterer09 no worries, we found out anyone can approve PRs on github ahah.

[PatrickAlphaC]

and @giovannidisiena, yes!

[rdotterer09]

Are you guys getting any closer to finishing this project? Just concerned about my losses in this lovely market crunch

[giovannidisiena]

Cool, should be ready for review now @PatrickAlphaC 😄

[pappas999]

thanks @giovannidisiena ! @andrejrakic can you please review

[andrejrakic]

Thanks for opening this PR, @giovannidisiena! Awesome job! However, I am not convinced that this example will be clear to developers, especially those new to Solidity. Maybe we can develop a more straightforward example that includes both checkData and performData.

[giovannidisiena]

Thanks @andrejrakic! Sure, that makes complete sense. Maybe if the timestamp fulfils some condition provided by checkData then checkUpkeep can return some performData upon which to act. Did you have any ideas?