feat: add solana grant role implementation#797
Open
ecPablo wants to merge 3 commits into
Open
Conversation
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
|
product-security-plaid-production
Bot
requested a review
from DimitriosNaikopoulos
| } | ||
| } | ||
|
|
||
| func TestTimelockRoleToBindingRejectsAdmin(t *testing.T) { |
Contributor
There was a problem hiding this comment.
nit: seems to be possible to consolidate the last two test functions in the test table; just need to add the typical wantErr attribute
| return types.TransactionResult{}, err | ||
| } | ||
|
|
||
| if c.skipSend { |
Contributor
There was a problem hiding this comment.
nit: I think it should be possible to use the same solution used for the Configurer type and embed instructionCollection. It should, in theory, reduce a bit of duplication.
| got, err := configurer.GrantRole(t.Context(), timelockAddress, sdk.TimelockRoleProposer, target.PublicKey().String()) | ||
|
|
||
| tt.assertion(t, err) | ||
| assert.Equal(t, tt.wantHash, got.Hash) |
Contributor
There was a problem hiding this comment.
if we have a parameterized assertion function, these other asserts should be inside it
gustavogama-cll
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds solana implementation for GrantRole on the
TimelockConfigurer. Some notes on the solana implementation: