fix(#398): remove unused Array1/ArrayView1 imports from svm/mod.rs - #431
Closed
Mec-iS wants to merge 9 commits into
Closed
fix(#398): remove unused Array1/ArrayView1 imports from svm/mod.rs#431Mec-iS wants to merge 9 commits into
Mec-iS wants to merge 9 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follows up on the dead-code cleanup in #398.
After removing
pub mod search;fromsvm/mod.rs, two imports that were only needed by the deletedsvm/search/subtree were left behind:Neither
Array1norArrayView1are used anywhere insvm/mod.rsitself — they were only transitively needed bysvc_params.rs/svr_params.rs. Leaving them in place triggers an unused-import warning (or#[expect]failure under the stricter lint setup introduced in the cleanup commits).Changes
src/svm/mod.rs— removed the staleArray1/ArrayView1import lineRelated