Fix CBOR deserializer crash on empty input for no-input operations#1103
Open
praguna14 wants to merge 1 commit intosmithy-lang:mainfrom
Open
Fix CBOR deserializer crash on empty input for no-input operations#1103praguna14 wants to merge 1 commit intosmithy-lang:mainfrom
praguna14 wants to merge 1 commit intosmithy-lang:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CborDeserializer.readStruct()crashes with"Can't read FINISHED as a struct"when deserializing operations that have no input members (empty request body)FINISHEDfor empty input, butreadStructonly acceptedSTART_OBJECT. Fixed by returning early when the token isFINISHED, skipping deserialization for empty input