Simplify HTTP header name handling to HeaderName#1125
Merged
Conversation
HeaderName is now a new way to make pre-canned canonicalized HTTP header names that can skip canonicalization when added/queried on messages or headers. Using these constants removes the need to do the fancy prefix tree scanning since that's now just for reading from external headers like Java HTTP client's. We are now also generating the bucketed GROUPS automatically rather than by hand. Performance between this version and the previous version that used the switch statements is the same.
kstich
approved these changes
Apr 1, 2026
sugmanue
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HeaderName is now a new way to make pre-canned canonicalized HTTP header names that can skip canonicalization when added/queried on messages or headers. Using these constants removes the need to do the fancy prefix tree scanning since that's now just for reading from external headers like Java HTTP client's. We are now also generating the bucketed GROUPS automatically rather than by hand.
Performance between this version and the previous version that used the switch statements is the same.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.