Skip to content

Signals styles#235

Open
JonanOribe wants to merge 3 commits into
smittix:mainfrom
JonanOribe:signals-styles
Open

Signals styles#235
JonanOribe wants to merge 3 commits into
smittix:mainfrom
JonanOribe:signals-styles

Conversation

@JonanOribe

Copy link
Copy Markdown
Contributor

The signal results boxes previously only occupied 50% of the screen width, making navigation cumbersome. Now, they utilize 100% of the available browser width, allowing users to view more boxes at a glance.

Original behavior:
original

New behavior:
new

@smittix

smittix commented Jun 23, 2026

Copy link
Copy Markdown
Owner

Thanks for tracking this down! The width issue is real — but the root cause is in applyViewState() in sensor-dashboard.js: it hides #output (the feed element) when the dashboard is active, but leaves its flex parent .pdir-feed-col visible in the layout. Since both .sdb-view and .pdir-feed-col have flex: 1, they split the space 50/50.

The CSS fix works, but it's a workaround — if any content in the feed column ever becomes visible alongside the dashboard, the 100% width guarantee would break.

We went with a JS fix instead: hide/restore .pdir-feed-col itself in applyViewState(). That way .sdb-view naturally fills the space with its original flex: 1, and the fix is robust to future changes in the column's content.

Commit a0be7d5 on main has the fix. Feel free to close this PR or rebase onto it — happy either way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants