ci: make Windows tool setup idempotent and silence LNK4315 - #70
Merged
Conversation
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| C & C++ |  |
Jul 26, 2026 11:34p.m. | Review ↗ |
| Docker | |
Jul 26, 2026 11:34p.m. | Review ↗ |
| Python | |
Jul 26, 2026 11:34p.m. | Review ↗ |
| Secrets | |
Jul 26, 2026 11:34p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
📝 WalkthroughSummary by CodeRabbit
WalkthroughWindows Bazel linking now ignores linker code 4315. Windows CI workflows use conditional WinGet package checks to install or update tools, and Windows Bazel jobs invoke tests through Bazelisk. ChangesWindows build and CI
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 447-448: Remove the “-r bazel” arguments from both Bazelisk
upgrade commands in .github/workflows/ci.yml at lines 447-448 and 494-495, while
preserving the Bazelisk package ID and ensuring the installation continues to
expose bazel for subsequent tests.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 4a95d35f-514c-4a57-ad05-dfdede48b4c8
📒 Files selected for processing (3)
.bazelrc.github/workflows/ci.yml.github/workflows/meson.yml
snape
force-pushed
the
fix-windows-builds
branch
from
July 26, 2026 00:14
aeeb257 to
0e6edf2
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 445-458: Replace each PowerShell `if (winget list --id …)`
condition with a WinGet existence check that suppresses command output and
branches on `$LASTEXITCODE`, or use `Get-WinGetPackage`. Apply this to
.github/workflows/ci.yml lines 445-458, 502-515, 982-995, and 1043-1056, plus
.github/workflows/meson.yml lines 415-435 and 477-497, preserving the existing
upgrade path for installed packages and install path for missing packages.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 0efa4907-4b3f-4aab-960c-33c2fb602944
📒 Files selected for processing (3)
.bazelrc.github/workflows/ci.yml.github/workflows/meson.yml
snape
force-pushed
the
fix-windows-builds
branch
2 times, most recently
from
July 26, 2026 00:32
490e810 to
7e6480b
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 454-456: Remove the `-r bazel` arguments from both Bazelisk
upgrade commands in `.github/workflows/ci.yml` at lines 454-456 and 511-513,
leaving each `winget upgrade` targeted only at `Bazel.Bazelisk`; retain `-r
bazel` on the install paths.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: d90f7dc4-4ee4-4828-9920-15c86b7bc704
📒 Files selected for processing (3)
.bazelrc.github/workflows/ci.yml.github/workflows/meson.yml
snape
force-pushed
the
fix-windows-builds
branch
14 times, most recently
from
July 26, 2026 23:28
db66d04 to
3062fd0
Compare
Signed-off-by: Jamie Snape <snape@me.com>
snape
force-pushed
the
fix-windows-builds
branch
from
July 26, 2026 23:34
3062fd0 to
8972520
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.bazelrc:
- Line 52: Replace the Windows build option on the affected .bazelrc entry with
the compiler warning-disable flag /wd4315, removing the linker-only /IGNORE:4315
option so C4315 is suppressed during compilation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: ba4aaa80-342f-4000-8c2a-983e5b8b6894
📒 Files selected for processing (3)
.bazelrc.github/workflows/ci.yml.github/workflows/meson.yml
snape
added a commit
that referenced
this pull request
Jul 27, 2026
Signed-off-by: Jamie Snape <snape@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.