feat(phpredis): add RedisArray client-side sharding support#758
Open
guillaumedelre wants to merge 2 commits into
Open
feat(phpredis): add RedisArray client-side sharding support#758guillaumedelre wants to merge 2 commits into
guillaumedelre wants to merge 2 commits into
Conversation
Adds support for phpredis native RedisArray, enabling client-side consistent hashing across multiple Redis nodes without a Redis Cluster setup. New `array: true` option under `clients.options` routes to a new `createArrayClient()` in PhpredisClientFactory. The Configuration class registers a `phpredis_arrayclient` class parameter defaulting to `RedisArray`. Signed-off-by: Guillaume Delré <delre.guillaume@gmail.com>
The 'array' config flag selects the RedisArray client class in loadPhpredisClient() but was not unset before passing options to the service Definition, causing it to leak into the factory. Also suppresses an InvalidArgument on RedisArray::setOption() where the Psalm callmap incorrectly types the value argument as string while phpredis accepts int for OPT_SERIALIZER at runtime. Signed-off-by: Guillaume Delré <delre.guillaume@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
array: trueoption underclients.optionsforphpredisclientsPhpredisClientFactory::createArrayClient()which instantiates a nativeRedisArrayphpredis_arrayclientclass parameter inConfiguration(defaults toRedisArray)arraykey before passing options to Predis clientsTest plan
testPhpRedisArrayOptionverifies class, DSNs, alias and options for aRedisArrayclienttestPhpRedisArrayIsNotSupported→testPhpRedisMultiDsnWithoutModeThrowswith updated error messagearray: falsedefaultRedisextension in test container)Closes #195