add hello solana asm example#538
Open
Perelyn-sama wants to merge 3 commits intosolana-developers:mainfrom
Open
add hello solana asm example#538Perelyn-sama wants to merge 3 commits intosolana-developers:mainfrom
Perelyn-sama wants to merge 3 commits intosolana-developers:mainfrom
Conversation
dev-jodee
requested changes
Mar 24, 2026
Collaborator
dev-jodee
left a comment
dev-jodee
left a comment
There was a problem hiding this comment.
Couple of small things to change :) thx for the work
Cargo.toml
Outdated
| solana-pubkey = "3.0.0" | ||
| solana-transaction = "3.0.1" | ||
| solana-native-token = "3.0.0" | ||
| solana-address = "2.1.0" |
Collaborator
There was a problem hiding this comment.
Doesn't seem used anywhere?
Collaborator
Author
There was a problem hiding this comment.
Collaborator
There was a problem hiding this comment.
Yes, but that dependency isn't used anywhere in your code itself
dev-jodee
reviewed
Mar 27, 2026
Collaborator
dev-jodee
left a comment
dev-jodee
left a comment
There was a problem hiding this comment.
re on the solana dependency added -> Yes, but that dependency isn't used anywhere in your code itself
Collaborator
Author
fair, removed. Also, thanks for the reviews. feels good to be making progress :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.