fix(codama): use PDA defaults instead of hardcoded public keys#32
Draft
fix(codama): use PDA defaults instead of hardcoded public keys#32
Conversation
Replace hardcoded public key defaults for `event_authority` and
`escrow_program` accounts with proper Codama IDL semantics:
- event_authority: use `pda("event_authority", [])` instead of static key
- escrow_program: mark as `optional` instead of hardcoding program ID
dev-jodee
previously approved these changes
Mar 25, 2026
Collaborator
Author
|
Changed to draft the Codama rust renderer is not happy w/ the change |
- borsh: enable derive feature for v3 generated code - solana-address: bump to ~2.2 with curve25519 feature for PDA methods - Remove solana-pubkey (v3 generates solana-address exclusively) - Fix generate-clients.ts for v3 renderVisitor API change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
public_key("Eq63FW...")default forevent_authoritywithpda("event_authority", [])across all instructionspublic_key("Escrowae7...")default forescrow_programwithoptionalmarker across all instructionsTest plan
just buildpasses