Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Caution Review failedThe pull request is closed. 워크스루이번 PR은 대학교 이름 매칭 로직을 개선하는 변경사항입니다. 다음과 같은 수정이 포함되어 있습니다:
예상 코드 리뷰 난이도🎯 3 (Moderate) | ⏱️ ~20 분 제안하는 리뷰어
✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
인하대학교와인하대모두 동일하게 처리하도록 수정했습니다.404(대학 미존재)응답도 notFound 대신 폴백 UI를 노출하도록 변경했습니다.Changed Files
apps/web/src/constants/university.tsapps/web/src/app/university/[homeUniversity]/page.tsxapps/web/src/app/university/[homeUniversity]/[id]/page.tsxapps/web/src/app/university/[homeUniversity]/[id]/_ui/UniversityDetailPreparingFallback.tsxapps/web/src/apis/universities/getSearchText.tsapps/web/src/apis/universities/getSearchFilter.tsVerification
lsp_diagnostics(modified files): no errorspnpm --filter @solid-connect/web run buildpnpm --filter @solid-connect/web run ci:check