Skip to content

fix: 메인 대학 카드 상세 링크를 홈대학 slug 기반으로 수정 #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manNomi merged 1 commit into from
Feb 20, 2026
Merged

fix: 메인 대학 카드 상세 링크를 홈대학 slug 기반으로 수정 #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion apps/web/src/app/(home)/_ui/PopularUniversitySection/_ui/PopularUniversityCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import Link from "next/link";
import Image from "@/components/ui/FallbackImage";
import { getHomeUniversitySlugByName } from "@/constants/university";
import type { ListUniversity } from "@/types/university";
import { convertImageUrl } from "@/utils/fileUtils";

Expand All @@ -18,8 +19,13 @@ const PopularUniversityCard = ({
fetchPriority = "low",
quality = 60, // 기본값을 60으로 낮춤
}: PopularUniversityCardProps) => {
const homeUniversitySlug = getHomeUniversitySlugByName(university.homeUniversityName);
const universityDetailHref = homeUniversitySlug
? `/university/${homeUniversitySlug}/${university.id}`
: "/university";
Comment on lines +22 to +25
Copy link

@coderabbitai coderabbitai bot Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

slug 미확인 시 폴백 URL에서 ID가 제외되는 동작을 확인해 주세요.

UniverSityCard와 동일하게, homeUniversitySlug가 undefined로 반환될 경우 href가 /university/{id} 대신 /university(목록 페이지)가 됩니다.

  • 이 컴포넌트는 메인 홈의 "인기 대학" 카드이므로 homeUniversityName이 항상 inha/incheon/sungshin 중 하나일 가능성이 높습니다.
  • 하지만 API 응답에서 homeUniversityName이 누락되거나 예상치 못한 값이 오면 카드가 목록 페이지로 이동해 사용자가 상세 정보에 접근하지 못할 수 있습니다.
  • /university/[id] 라우트가 제거됐다면 /university가 최선의 폴백이 맞지만, 존재한다면 "/university" 대신 `/university/${university.id}`를 폴백으로 사용하는 것이 더 견고합니다.
🛡️ 폴백에 ID를 포함하는 예시 (라우트가 여전히 존재하는 경우) 
  const universityDetailHref = homeUniversitySlug
    ? `/university/${homeUniversitySlug}/${university.id}`
-   : "/university";
+   : `/university/${university.id}`;
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In
`@apps/web/src/app/`(home)/_ui/PopularUniversitySection/_ui/PopularUniversityCard.tsx
around lines 22 - 25, The current logic building universityDetailHref uses
getHomeUniversitySlugByName and drops the university ID when homeUniversitySlug
is falsy, causing links to point to "/university" instead of the specific
detail; update the construction of universityDetailHref in PopularUniversityCard
so that when homeUniversitySlug is undefined it falls back to
`/university/${university.id}` (i.e., include university.id in the fallback),
ensuring links still navigate to the university detail page; modify the
expression that assigns universityDetailHref (references:
getHomeUniversitySlugByName, homeUniversitySlug, universityDetailHref,
university.id) to use the ID-based URL as the fallback.


return (
<Link key={university.id} href={`/university/${university.id}`}>
<Link key={university.id} href={universityDetailHref}>
<div className="relative w-[153px]">
<div className="relative h-[120px] w-[153px] overflow-hidden rounded-lg bg-k-700">
<Image
Expand Down
15 changes: 10 additions & 5 deletions apps/web/src/components/ui/UniverSityCard/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import Link from "next/link";
import Image from "@/components/ui/FallbackImage";
import CheveronRightFilled from "@/components/ui/icon/ChevronRightFilled";
import { getHomeUniversitySlugByName } from "@/constants/university";
import type { ListUniversity } from "@/types/university";
import { convertImageUrl } from "@/utils/fileUtils";
import shortenLanguageTestName from "@/utils/universityUtils";
Expand All @@ -17,12 +18,16 @@ const UniversityCard = ({ university, showCapacity = true, linkPrefix = "/univer
? `${university.koreanName}(${university.term})`
: university.koreanName;

const mappedHomeUniversitySlug = getHomeUniversitySlugByName(university.homeUniversityName);
const hasExplicitPrefix = linkPrefix !== "/university";
const universityDetailHref = mappedHomeUniversitySlug
? `/university/${mappedHomeUniversitySlug}/${university.id}`
: hasExplicitPrefix
? `${linkPrefix}/${university.id}`
: "/university";
Comment on lines +21 to +27
Copy link

@coderabbitai coderabbitai bot Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check the structure of the university routes in the Next.js app directory
find apps/web/src/app -type d -name "*university*" 2>/dev/null | sort

Repository: solid-connection/solid-connect-web

Length of output: 105

🏁 Script executed:

#!/bin/bash
# List the contents of the university-related directories to see route patterns
if [ -d "apps/web/src/app" ]; then
  find apps/web/src/app -path "*university*" -type f -name "*.tsx" -o -path "*university*" -type f -name "*.ts" -o -path "*university*" -type f -name "page.tsx" | sort
fi

Repository: solid-connection/solid-connect-web

Length of output: 3384

🏁 Script executed:

#!/bin/bash
# Check for the specific route patterns: [id] and [slug]/[id]
find apps/web/src/app -type f \( -name "page.tsx" -o -name "layout.tsx" \) | xargs grep -l "university" 2>/dev/null | head -20

Repository: solid-connection/solid-connect-web

Length of output: 433

🏁 Script executed:

#!/bin/bash
# Read the UniversityCard component
cat -n apps/web/src/components/ui/UniverSityCard/index.tsx

Repository: solid-connection/solid-connect-web

Length of output: 4036

🏁 Script executed:

#!/bin/bash
# Find and examine the getHomeUniversitySlugByName function
rg "getHomeUniversitySlugByName" --type ts --type tsx -B 2 -A 5 | head -50

Repository: solid-connection/solid-connect-web

Length of output: 105

🏁 Script executed:

#!/bin/bash
# Check how UniversityCard is used/imported
rg "UniverSityCard|UniversityCard" --type ts --type tsx | grep -E "import|from" | head -20

Repository: solid-connection/solid-connect-web

Length of output: 105

🏁 Script executed:

#!/bin/bash
# Find the getHomeUniversitySlugByName function
rg "getHomeUniversitySlugByName" --type ts -B 2 -A 10

Repository: solid-connection/solid-connect-web

Length of output: 6579

🏁 Script executed:

#!/bin/bash
# Check where UniversityCard is used and with what props
rg "UniverSityCard" --type ts | head -30

Repository: solid-connection/solid-connect-web

Length of output: 312

🏁 Script executed:

#!/bin/bash
# Check imports of UniversityCard to see usage contexts
rg "from.*UniverSityCard|import.*UniverSityCard" --type ts

Repository: solid-connection/solid-connect-web

Length of output: 312

🏁 Script executed:

#!/bin/bash
# Check UniversityCards component to see how it uses UniversityCard
cat -n apps/web/src/components/university/UniversityCards/index.tsx

Repository: solid-connection/solid-connect-web

Length of output: 1062

🏁 Script executed:

#!/bin/bash
# Check FavoriteContent component to see how it uses UniversityCard
cat -n apps/web/src/app/my/favorite/_ui/FavoriteContent/index.tsx

Repository: solid-connection/solid-connect-web

Length of output: 4157

🏁 Script executed:

#!/bin/bash
# Search for any usage of UniversityCard with linkPrefix prop
rg "UniversityCard|UniverSityCard" --type ts -A 3 -B 1 | grep -E "linkPrefix|UniverSityCard|UniversityCard" | head -40

Repository: solid-connection/solid-connect-web

Length of output: 4101

🏁 Script executed:

#!/bin/bash
# Search for all places where UniversityCards is used with linkPrefix
rg "UniversityCards" --type ts -B 2 -A 2 | grep -E "linkPrefix|UniversityCards"

Repository: solid-connection/solid-connect-web

Length of output: 2306

🏁 Script executed:

#!/bin/bash
# Check UniversityListContent to see the full context of linkPrefix usage
cat -n apps/web/src/app/university/[homeUniversity]/_ui/UniversityListContent.tsx | head -50

Repository: solid-connection/solid-connect-web

Length of output: 2113

🏁 Script executed:

#!/bin/bash
# Continue reading to see the full linkPrefix usage
cat -n apps/web/src/app/university/[homeUniversity]/_ui/UniversityListContent.tsx | tail -30

Repository: solid-connection/solid-connect-web

Length of output: 1261

URL 폴백 로직 재검토 요청

현재 라우팅 구조를 확인한 결과, 다음을 안내합니다.

  1. ID-only 라우트 폴백 관련

    • /university/[homeUniversity]/[id]가 유일한 대학 상세 페이지 라우트입니다
    • /university/[id] (slug 없는 경로)는 존재하지 않습니다
    • homeUniversityName 매핑 실패 시 /university로 폴백하는 것은 의도된 동작입니다

  2. linkPrefix 우선순위 관련

    • mappedHomeUniversitySlug가 존재하면 linkPrefix가 무시되는 로직은 설계상 의도된 것으로 보입니다
    • 현재 코드베이스에서는 linkPrefix={/university/${homeUniversitySlug}}로 이미 slug가 포함되어 전달되므로 문제가 없습니다
    • 다만 이 우선순위 규칙을 명확히 문서화하거나, 향후 비-퍼블릭 컨텍스트(예: 어드민 페이지)에서 재사용될 경우를 대비해 조건을 재검토할 것을 권장합니다
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@apps/web/src/components/ui/UniverSityCard/index.tsx` around lines 21 - 27,
The URL fallback and priority rules around getHomeUniversitySlugByName,
mappedHomeUniversitySlug, linkPrefix and universityDetailHref are unclear;
either make the current behavior explicit or change it: if you want to keep the
existing rule (mappedHomeUniversitySlug wins and missing slug falls back to
"/university"), add a concise inline comment above the universityDetailHref
computation documenting that mappedHomeUniversitySlug takes precedence and that
missing mapping intentionally falls back to "/university"; if instead linkPrefix
should be allowed to override even when mappedHomeUniversitySlug exists, flip
the condition so hasExplicitPrefix is checked before mappedHomeUniversitySlug
(i.e., prefer linkPrefix when provided), and update the comment accordingly.


return (
<Link
className="block"
href={`${linkPrefix}/${university.id}`}
aria-labelledby={`university-name-${university.id}`}
>
<Link className="block" href={universityDetailHref} aria-labelledby={`university-name-${university.id}`}>
<div className="relative h-[91px] w-full overflow-hidden rounded-lg border border-solid border-k-100 hover:-translate-y-0.5 hover:shadow-md hover:shadow-black/10">
<div className="flex justify-between px-5 py-3.5">
<div className="flex gap-[23.5px]">
Expand Down
10 changes: 10 additions & 0 deletions apps/web/src/constants/university.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,16 @@ export const isMatchedHomeUniversityName = (
return normalizedLeft !== undefined && normalizedRight !== undefined && normalizedLeft === normalizedRight;
};

export const getHomeUniversitySlugByName = (value: string | null | undefined): HomeUniversitySlug | undefined => {
const normalizedUniversityName = normalizeHomeUniversityName(value);

if (!normalizedUniversityName) {
return undefined;
}

return HOME_UNIVERSITY_TO_SLUG_MAP[normalizedUniversityName];
};

/**
* 유효한 홈 대학교 슬러그 목록
*/
Expand Down