Run legacy promotion handler "cart" if legacy promo system present#309
Open
mamhoff wants to merge 1 commit intosolidusio:mainfrom
Open
Run legacy promotion handler "cart" if legacy promo system present#309mamhoff wants to merge 1 commit intosolidusio:mainfrom
mamhoff wants to merge 1 commit intosolidusio:mainfrom
Conversation
mamhoff
force-pushed
the
fix-legacy-promotion-handling
branch
from
57a1ba9 to
0f2fcd8
Compare
In the legacy promotion system, there's a separation of tasks between `order.recalculate` and `PromotionHandler::Cart`. `order.recalculate` will only recalculate already existing promotion adjustments, but will not check for any new promotions that might need to be applied. In the new promotion system, both of these tasks are handled by `order.recalculate`. If the legacy promotion system is present, but not active, calling this promotion handler will result in a single database call, which is an acceptable price to pay I think.
mamhoff
force-pushed
the
fix-legacy-promotion-handling
branch
from
0f2fcd8 to
61c77ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the legacy promotion system, there's a separation of tasks between
order.recalculateandPromotionHandler::Cart.order.recalculatewill only recalculate already existing promotion adjustments, but will not check for any new promotions that might need to be applied. In the new promotion system, both of these tasks are handled byorder.recalculate.If the legacy promotion system is present, but not active, calling this promotion handler will result in a single database call, which is an acceptable price to pay I think.