Add architecture fence to Ubuntu mmdv build script#808
Closed
ctmd1234567 wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds an early host-architecture guard to the Ubuntu 24.04 dependency build script to fail fast on unsupported platforms.
Changes:
- Detects host architecture via
uname -m. - Exits with an error message when architecture is not x86_64/amd64.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+76
to
+84
| MMDV_ARCH="$(uname -m)" | ||
| case "${MMDV_ARCH}" in | ||
| x86_64|amd64) | ||
| ;; | ||
| *) | ||
| echo "Unsupported architecture: ${MMDV_ARCH}. This script currently supports x86-64 only." >&2 | ||
| exit 1 | ||
| ;; | ||
| esac |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #807
This adds an early architecture check to the Ubuntu 24.04 mmdv build script. The script now allows x86_64/amd64 and fails fast with a clear error message on unsupported architectures.
Tested: