Skip to content

Upgrade Core to aa314809fdb59ed6fcb1b10b3087f32eebf708c5#912

Merged
jviotti merged 1 commit into
mainfrom
core-blaze-io
May 12, 2026
Merged

Upgrade Core to aa314809fdb59ed6fcb1b10b3087f32eebf708c5#912
jviotti merged 1 commit into
mainfrom
core-blaze-io

Conversation

@jviotti
Copy link
Copy Markdown
Member

@jviotti jviotti commented May 12, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 334 files

Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
On a pro plan you can use ultrareview for larger PRs.

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 12, 2026

🤖 Augment PR Summary

Summary: Updates vendored dependencies (Core and Blaze) to newer revisions, and adapts JSONBinPack’s runtime I/O helpers to the updated Core APIs.

Changes:

  • Bumped core and blaze pins in DEPENDENCIES (and updated vendored trees accordingly).
  • Runtime InputStream/OutputStream now build on Core’s BinaryReader/BinaryWriter abstractions.
  • Replaced the standalone varint.h helper with inline varint encode/decode logic in the stream implementation files.
  • Updated date-triplet encoding to use word writes (put_word) rather than raw byte writes.
  • Adjusted runtime CMake linkage to include the Core I/O component (sourcemeta::core::io).
  • Vendor Blaze picks up additional optional components (e.g., codegen/documentation) and related test/doc assets.

Technical Notes: The runtime stream changes centralize endian handling in Core’s I/O layer and reduce local I/O code duplication, but also introduce a new explicit dependency on Core’s I/O target for consumers.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

#ifndef NDEBUG
const std::uint64_t current = result;
#endif
result += static_cast<std::uint64_t>(value << SHIFT * cursor);
Copy link
Copy Markdown

@augmentcode augmentcode Bot May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InputStream::get_varint() lets cursor grow without a hard cap, so value << (SHIFT * cursor) becomes undefined once the shift reaches/exceeds 64 bits (and a malformed varint can also force a long decode loop). Consider enforcing a maximum byte count for 64-bit varints before shifting.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

sourcemeta::core::json)
target_link_libraries(sourcemeta_jsonbinpack_runtime PUBLIC
sourcemeta::core::numeric)
target_link_libraries(sourcemeta_jsonbinpack_runtime PUBLIC
Copy link
Copy Markdown

@augmentcode augmentcode Bot May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runtime now links against sourcemeta::core::io, but config.cmake.in still calls find_dependency(Core COMPONENTS ...) without io, which can break consumers using find_package(JSONBinPack). Consider adding the Core io component there to match the runtime target’s transitive requirements.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@jviotti jviotti merged commit 73414f1 into main May 12, 2026
13 checks passed
@jviotti jviotti deleted the core-blaze-io branch May 12, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant