Upgrade Core to aa314809fdb59ed6fcb1b10b3087f32eebf708c5#912
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
There was a problem hiding this comment.
No issues found across 334 files
Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
On a pro plan you can use ultrareview for larger PRs.
🤖 Augment PR SummarySummary: Updates vendored dependencies (Core and Blaze) to newer revisions, and adapts JSONBinPack’s runtime I/O helpers to the updated Core APIs. Changes:
Technical Notes: The runtime stream changes centralize endian handling in Core’s I/O layer and reduce local I/O code duplication, but also introduce a new explicit dependency on Core’s I/O target for consumers. 🤖 Was this summary useful? React with 👍 or 👎 |
| #ifndef NDEBUG | ||
| const std::uint64_t current = result; | ||
| #endif | ||
| result += static_cast<std::uint64_t>(value << SHIFT * cursor); |
There was a problem hiding this comment.
InputStream::get_varint() lets cursor grow without a hard cap, so value << (SHIFT * cursor) becomes undefined once the shift reaches/exceeds 64 bits (and a malformed varint can also force a long decode loop). Consider enforcing a maximum byte count for 64-bit varints before shifting.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| sourcemeta::core::json) | ||
| target_link_libraries(sourcemeta_jsonbinpack_runtime PUBLIC | ||
| sourcemeta::core::numeric) | ||
| target_link_libraries(sourcemeta_jsonbinpack_runtime PUBLIC |
There was a problem hiding this comment.
Runtime now links against sourcemeta::core::io, but config.cmake.in still calls find_dependency(Core COMPONENTS ...) without io, which can break consumers using find_package(JSONBinPack). Consider adding the Core io component there to match the runtime target’s transitive requirements.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com