Skip to content

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Jan 5, 2026

Signed-off-by: Juan Cruz Viotti [email protected]

@augmentcode
Copy link

augmentcode bot commented Jan 5, 2026

🤖 Augment PR Summary

Summary: This PR updates the vendored sourcemeta/core dependency to commit 02a6f9f3….

Changes:

  • Bumps the core entry in DEPENDENCIES to the new pinned SHA.
  • Extends JSON Schema bundling to accept an exclusions set, allowing specific referenced IDs to be skipped during bundling.
  • Replaces the expensive SchemaFrame::references_to() vector-building API with faster boolean checks: has_references_to() and has_references_through().
  • Updates multiple alterschema transformation/linter rules to avoid deleting keywords when references would traverse them, reducing the risk of producing broken references.
  • Updates UnnecessaryAllOfWrapper to use the new reference-check API.

Technical Notes: The new reference checks appear intended to be conservative (especially for dynamic references) and should improve both correctness and performance of schema transforms/bundling.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

const SchemaFrame::Paths &paths = {empty_pointer},
const std::unordered_set<std::string_view> &exclusions = {})
-> void;

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exclusions is an std::unordered_set<std::string_view> (non-owning); consider documenting that the referenced strings must outlive the bundle() call and what exact identifier form is expected. (Also applies to the const JSON& overload below.)

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎

@jviotti jviotti closed this Jan 5, 2026
@jviotti jviotti deleted the core-02 branch January 5, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants