Skip to content

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Dec 29, 2025

Signed-off-by: Juan Cruz Viotti [email protected]

Signed-off-by: Juan Cruz Viotti <[email protected]>
@augmentcode
Copy link

augmentcode bot commented Dec 29, 2025

🤖 Augment PR Summary

Summary: This PR expands the BIPM SI (2019) catalog by adding commonly used non‑SI units accepted for use with the SI.

Changes:

  • Introduces new JSON Schema definitions under schemas/2020-12/bipm/si/2019/non-si/unit/ for: degree, arcminute, arcsecond, minute, hour, day, litre, hectare, tonne, electronvolt, dalton, and astronomical unit.
  • Each unit schema includes metadata such as x-symbol and x-si-equivalent, plus examples and (where appropriate) minimum: 0 constraints.
  • Adds corresponding schema test vectors under test/bipm/si/2019/non-si/unit/ to validate numeric typing and sign constraints.
  • Updates the Makefile to define JQ and MKDIRP variables for tool customization in build/QA scripts.

Technical Notes: The new unit schemas follow the existing BIPM schema patterns (draft 2020-12, Sourcemeta metadata extensions) and are paired 1:1 with test files to satisfy the repository’s schema-test mirroring checks.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@jviotti jviotti merged commit c5e91fc into main Dec 29, 2025
2 checks passed
@jviotti jviotti deleted the non-si-units branch December 29, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants