Skip to content

ci: uploading coverage to codecov.io#97

Draft
glimchb wants to merge 1 commit intospdk:mainfrom
glimchb:codecovio
Draft

ci: uploading coverage to codecov.io#97
glimchb wants to merge 1 commit intospdk:mainfrom
glimchb:codecovio

Conversation

@glimchb
Copy link
Copy Markdown
Contributor

@glimchb glimchb commented Aug 18, 2025

Add Codecov integration to the summary workflow to upload combined
coverage report (ut_cov_total.info) for the spdk/spdk repository.

  • Use OIDC authentication (no static token needed)
  • Use override_commit to map coverage to the tested SPDK commit
  • Use disable_search to only upload the specified file
  • Add permissions block to gerrit-webhook-handler.yml so the
    id-token:write permission propagates to the summary workflow

see example : https://app.codecov.io/gh/glimchb/spdk
and badge : codecov

Comment thread .github/workflows/summary.yml Outdated
@karlatec
Copy link
Copy Markdown
Contributor

I think you uploaded the artifact to codecov using a fork of SPDK Github repo as the code base, correct?
In that case this works all fine:
I can go to https://app.codecov.io/gh/glimchb/spdk/commit/ed1cc0a7aeff5ad5ef94cc200c6133158b0e9523 and then click 7 months ago glimchb authored commit ed1cc0a, which takes me to related commit in your SPDK fork. Using SPDK repo from Github also makes it possible for CodeCov to show coverage diff.

But there's going to be an issue with uploading & comparing coverage statistics for changes which are still in review (i.e. on Gerrit). In this case Codecov get's confused and can't fetch commit message, author, resolve history, etc.
See for example:
https://app.codecov.io/gh/karlatec/spdk/commits
https://app.codecov.io/gh/karlatec/spdk/commit/a5d76ac2bf379a48939fc174591d42c3f408f618

I'm not "against", just pointing this out.
Using Codecov for generating coverage statistics on already merged code (e.g. as part of some "nightly" tests) is going to be easy. Integrating it with Gerrit to deliver coverage-diff information for each patch is going to take a bit more work.

@glimchb glimchb marked this pull request as draft March 3, 2026 20:56
@glimchb glimchb added the enhancement New feature or request label Mar 3, 2026
@glimchb glimchb force-pushed the codecovio branch 3 times, most recently from 0aa133d to 94111d7 Compare March 7, 2026 23:23
Add Codecov integration to the summary workflow to upload combined
coverage report (ut_cov_total.info) for the spdk/spdk repository.

- Use OIDC authentication (no static token needed)
- Use override_commit to map coverage to the tested SPDK commit
- Use disable_search to only upload the specified file
- Add permissions block to gerrit-webhook-handler.yml so the
  id-token:write permission propagates to the summary workflow

Generated with [Devin](https://cli.devin.ai/docs)

Co-Authored-By: Devin <noreply@cognition.ai>
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants