feat(w3c/headers): validate header links#4037
Closed
marcoscaceres wants to merge 3 commits intomainfrom
Closed
Conversation
sidvishnoi
reviewed
Feb 16, 2022
Member
sidvishnoi
left a comment
sidvishnoi
left a comment
There was a problem hiding this comment.
Will check in detail from computer.
sidvishnoi
reviewed
Feb 18, 2022
Comment on lines
+37
to
+40
| ${conf.latestVersion !== null | ||
| ? html`<dt>${l10n.latest_published_version}</dt> | ||
| <dd> | ||
| ${conf.latestVersion | ||
| ${conf.latestVersion !== "" |
Member
There was a problem hiding this comment.
When is it null, and when is it "" in particular?
Contributor
Author
There was a problem hiding this comment.
When it's null, it shouldn't be included... but when it's ""... I need to check :(
marcoscaceres
force-pushed
the
validate_latest
branch
from
0f3940b to
8d2de1b
Compare
✅ Deploy Preview for respec-pr ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
marcoscaceres
added a commit
that referenced
this pull request
Mar 27, 2026
- Warn if latestVersion URL doesn't resolve (non-FPWD docs) - CG drafts (specStatus ending in -DRAFT) no longer require latestVersion - Extract resourceExists() helper that returns the final URL after redirects (or null), replacing ad-hoc fetch+ok patterns - deriveHistoryURI() now returns a value instead of mutating conf, and uses resourceExists() to avoid duplicating fetch logic - Guard conf.historyURI = null (user suppression) at the call site so explicit null is not overwritten by derivation - Fix URL construction: use response.url (post-redirect) for the history URL rather than the pre-redirect constructed URL Fixes #4037 (rebased from validate_latest branch)
marcoscaceres
added a commit
that referenced
this pull request
Mar 28, 2026
- Warn if latestVersion URL doesn't resolve (non-FPWD docs) - CG drafts (specStatus ending in -DRAFT) no longer require latestVersion - Extract resourceExists() helper that returns the final URL after redirects (or null), replacing ad-hoc fetch+ok patterns - deriveHistoryURI() now returns a value instead of mutating conf, and uses resourceExists() to avoid duplicating fetch logic - Guard conf.historyURI = null (user suppression) at the call site so explicit null is not overwritten by derivation - Fix URL construction: use response.url (post-redirect) for the history URL rather than the pre-redirect constructed URL Fixes #4037 (rebased from validate_latest branch)
marcoscaceres
added a commit
that referenced
this pull request
Mar 28, 2026
- Warn if latestVersion URL doesn't resolve (non-FPWD docs) - CG drafts (specStatus ending in -DRAFT) no longer require latestVersion - Extract resourceExists() helper that returns the final URL after redirects (or null), replacing ad-hoc fetch+ok patterns - deriveHistoryURI() now returns a value instead of mutating conf, and uses resourceExists() to avoid duplicating fetch logic - Guard conf.historyURI = null (user suppression) at the call site so explicit null is not overwritten by derivation - Fix URL construction: use response.url (post-redirect) for the history URL rather than the pre-redirect constructed URL Fixes #4037 (rebased from validate_latest branch)
marcoscaceres
added a commit
that referenced
this pull request
Mar 28, 2026
- Warn if latestVersion URL doesn't resolve (non-FPWD docs) - CG drafts (specStatus ending in -DRAFT) no longer require latestVersion - Extract resourceExists() helper that returns the final URL after redirects (or null), replacing ad-hoc fetch+ok patterns - deriveHistoryURI() now returns a value instead of mutating conf, and uses resourceExists() to avoid duplicating fetch logic - Guard conf.historyURI = null (user suppression) at the call site so explicit null is not overwritten by derivation - Fix URL construction: use response.url (post-redirect) for the history URL rather than the pre-redirect constructed URL Fixes #4037 (rebased from validate_latest branch)
marcoscaceres
added a commit
that referenced
this pull request
Mar 28, 2026
- Warn if latestVersion URL doesn't resolve (non-FPWD docs) - CG drafts (specStatus ending in -DRAFT) no longer require latestVersion - Extract resourceExists() helper that returns the final URL after redirects (or null), replacing ad-hoc fetch+ok patterns - deriveHistoryURI() now returns a value instead of mutating conf, and uses resourceExists() to avoid duplicating fetch logic - Guard conf.historyURI = null (user suppression) at the call site so explicit null is not overwritten by derivation - Fix URL construction: use response.url (post-redirect) for the history URL rather than the pre-redirect constructed URL Fixes #4037 (rebased from validate_latest branch)
marcoscaceres
added a commit
that referenced
this pull request
Mar 28, 2026
- Warn if latestVersion URL doesn't resolve (non-FPWD docs) - CG drafts (specStatus ending in -DRAFT) no longer require latestVersion - Extract resourceExists() helper that returns the final URL after redirects (or null), replacing ad-hoc fetch+ok patterns - deriveHistoryURI() now returns a value instead of mutating conf, and uses resourceExists() to avoid duplicating fetch logic - Guard conf.historyURI = null (user suppression) at the call site so explicit null is not overwritten by derivation - Fix URL construction: use response.url (post-redirect) for the history URL rather than the pre-redirect constructed URL Fixes #4037 (rebased from validate_latest branch)
marcoscaceres
added a commit
that referenced
this pull request
Apr 13, 2026
- Warn if latestVersion URL doesn't resolve (non-FPWD docs) - CG drafts (specStatus ending in -DRAFT) no longer require latestVersion - Extract resourceExists() helper that returns the final URL after redirects (or null), replacing ad-hoc fetch+ok patterns - deriveHistoryURI() now returns a value instead of mutating conf, and uses resourceExists() to avoid duplicating fetch logic - Guard conf.historyURI = null (user suppression) at the call site so explicit null is not overwritten by derivation - Fix URL construction: use response.url (post-redirect) for the history URL rather than the pre-redirect constructed URL Fixes #4037 (rebased from validate_latest branch)
marcoscaceres
added a commit
that referenced
this pull request
Apr 20, 2026
- Warn if latestVersion URL doesn't resolve (non-FPWD docs) - CG drafts (specStatus ending in -DRAFT) no longer require latestVersion - Extract resourceExists() helper that returns the final URL after redirects (or null), replacing ad-hoc fetch+ok patterns - deriveHistoryURI() now returns a value instead of mutating conf, and uses resourceExists() to avoid duplicating fetch logic - Guard conf.historyURI = null (user suppression) at the call site so explicit null is not overwritten by derivation - Fix URL construction: use response.url (post-redirect) for the history URL rather than the pre-redirect constructed URL Fixes #4037 (rebased from validate_latest branch)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complains if latestVersion doesn't exist, while it also prevents CG drafts from claiming to have a latestVersion.