Conversation
…for improved readability
…cy in build.gradle
… related projects section
… bugs along the way.
…s and ensuring atomic moves and cleanup
…l stop testing it.
…ne, SpecsAsm, and ProvidersSupport
…eadability and performance
There was a problem hiding this comment.
Pull request overview
This PR focuses on deprecating LARA DSL usage by migrating test files from JUnit 4 to JUnit 5 (Jupiter), adding comprehensive test coverage, improving code documentation, and fixing minor code issues.
Key changes:
- Migration from JUnit 4 to JUnit 5 for existing tests
- Addition of extensive new test suites for members, class types, enums, expressions, and utilities
- Enhanced JavaDoc documentation across multiple source files
- Code quality improvements including removal of duplicate license text and modernization of Java patterns
Reviewed changes
Copilot reviewed 183 out of 1035 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| JavaGenerator/test/org/specs/generators/java/members/FieldTest.java | New comprehensive test suite for Field class with 627 lines covering all field operations |
| JavaGenerator/test/org/specs/generators/java/members/EnumItemTest.java | New test suite for EnumItem with 494 lines testing enum constant generation |
| JavaGenerator/test/org/specs/generators/java/members/ConstructorTest.java | New test suite for Constructor with 507 lines testing constructor generation |
| JavaGenerator/test/org/specs/generators/java/members/ArgumentTest.java | New test suite for Argument with 373 lines testing method parameter handling |
| JavaGenerator/test/org/specs/generators/java/junit/MethodTest.java | Updated JUnit 4 to JUnit 5 imports and assertions |
| JavaGenerator/test/org/specs/generators/java/junit/JavaTypeTest.java | Updated JUnit 4 to JUnit 5 imports and assertions |
| JavaGenerator/test/org/specs/generators/java/junit/FieldTest.java | Updated JUnit 4 to JUnit 5 imports and removed deprecated assertion message parameter |
| JavaGenerator/test/org/specs/generators/java/exprs/IExpressionTest.java | New comprehensive test suite for IExpression interface with 464 lines |
| JavaGenerator/test/org/specs/generators/java/exprs/GenericExpressionTest.java | New test suite for GenericExpression with 312 lines |
| JavaGenerator/test/org/specs/generators/java/enums/PrivacyTest.java | New test suite for Privacy enum with 452 lines |
| JavaGenerator/test/org/specs/generators/java/enums/ObjectOfPrimitivesTest.java | New test suite for ObjectOfPrimitives enum with 545 lines |
| JavaGenerator/test/org/specs/generators/java/enums/NumeralTypeTest.java | New test suite for NumeralType enum with 434 lines |
| JavaGenerator/test/org/specs/generators/java/enums/ModifierTest.java | New test suite for Modifier enum with 386 lines |
| JavaGenerator/test/org/specs/generators/java/enums/JDocTagTest.java | New test suite for JDocTag enum with 387 lines |
| JavaGenerator/test/org/specs/generators/java/enums/AnnotationTest.java | New test suite for Annotation enum with 322 lines |
| JavaGenerator/test/org/specs/generators/java/classtypes/JavaEnumTest.java | New test suite for JavaEnum class with 453 lines |
| JavaGenerator/test/org/specs/generators/java/classtypes/JavaClassTest.java | New test suite for JavaClass with 594 lines |
| JavaGenerator/test/org/specs/generators/java/classtypes/InterfaceTest.java | New test suite for Interface class with 467 lines |
| JavaGenerator/test/org/specs/generators/java/classtypes/ClassTypeTest.java | New test suite for ClassType abstract class with 557 lines |
| JavaGenerator/test/org/specs/generators/java/IGenerateTest.java | New test suite for IGenerate interface with 233 lines |
| JavaGenerator/src/org/specs/generators/java/utils/Utils.java | Enhanced documentation, modernized code patterns, and removed duplicate license text |
| JavaGenerator/src/org/specs/generators/java/utils/UniqueList.java | Added JavaDoc, @serial annotation, and fixed return values in addAll methods |
| JavaGenerator/src/org/specs/generators/java/units/CompilationUnit.java | Enhanced JavaDoc documentation and removed duplicate license text |
| JavaGenerator/src/org/specs/generators/java/types/Primitive.java | Added JavaDoc documentation, improved Character wrapper handling |
| JavaGenerator/src/org/specs/generators/java/types/JavaTypeFactory.java | Enhanced JavaDoc, improved primitive wrapper detection, added Character handling |
| JavaGenerator/src/org/specs/generators/java/types/JavaType.java | Fixed array type handling, added equals/hashCode, modernized string operations |
| JavaGenerator/src/org/specs/generators/java/statements/IStatement.java | Added JavaDoc documentation and removed duplicate license text |
| JavaGenerator/src/org/specs/generators/java/exprs/IExpression.java | Added JavaDoc documentation and removed duplicate license text |
| JavaGenerator/settings.gradle | Updated build dependency paths from absolute to relative |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JavaGenerator/src/org/specs/generators/java/types/JavaType.java
Outdated
Show resolved
Hide resolved
JacksonPlus/test/pt/up/fe/specs/JacksonPlus/SpecsJacksonTest.java
Dismissed
Show dismissed
Hide dismissed
SpecsUtils/test/pt/up/fe/specs/util/treenode/transform/impl/DefaultTransformResultTest.java
Dismissed
Show dismissed
Hide dismissed
…ed the Z3Helper project as it was deprecated. All code was deleted because it was unused or deprecated.
- Updated multiple instances across various classes to replace SpecsLogs.getLogger().warning with SpecsLogs.warn for improved readability and consistency in logging practices. - This change enhances the clarity of log messages throughout the codebase, ensuring a uniform approach to logging warnings.
…ode' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
SpecsUtils/test/pt/up/fe/specs/util/events/EventActionTest.java
Dismissed
Show dismissed
Hide dismissed
joaobispo
reviewed
Dec 28, 2025
joaobispo
reviewed
Dec 28, 2025
…on StackOverflow code and are still in use in private projects. This partially reverts commit d476eee.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.