Skip to content

Fixed redirects, UI improvements#262

Merged
lucaspar merged 11 commits intomasterfrom
lp/wip
Feb 25, 2026
Merged

Fixed redirects, UI improvements#262
lucaspar merged 11 commits intomasterfrom
lp/wip

Conversation

@lucaspar
Copy link
Member

@lucaspar lucaspar commented Feb 24, 2026

Fixes SFDS-314

  • Bug Fixes & Security
    • Resolved SFDS-314 (redirects in unauthenticated home).
    • Removed auth requirement from that view, to render public dataset information when not authenticated.
    • Added security checks for templates.
  • Dependencies & Configuration
    • Resolved a Pydantic v2 deprecation warning: Config class.
    • Enabling template debug flag in local.py.
  • Testing
    • Updated test expectations.
    • Added tests for invalid views (security checks).
  • UI Improvements
    • Improvements to coherence: header of file listing now matches datasets and captures.
    • Added icons to navbar entries.
  • Refactoring
    • Renamed file_list to capture_list for consistency and clarity.

@lucaspar lucaspar self-assigned this Feb 24, 2026
Copilot AI review requested due to automatic review settings February 24, 2026 19:25
@lucaspar lucaspar added bug Something isn't working gateway Gateway component styling Special focus on styling of front-end components javascript Pull requests that update non-trivial javascript code labels Feb 24, 2026
@semanticdiff-com
Copy link

semanticdiff-com bot commented Feb 24, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  gateway/sds_gateway/templates/base.html  73% smaller
  gateway/sds_gateway/static/css/file-manager.css  71% smaller
  gateway/sds_gateway/templates/emails/item_download_error.html  66% smaller
  gateway/sds_gateway/users/views.py  30% smaller
  gateway/sds_gateway/users/urls.py  16% smaller
  gateway/sds_gateway/api_methods/serializers/dataset_serializers.py  5% smaller
  gateway/config/settings/local.py  0% smaller
  gateway/justfile Unsupported file format
  gateway/sds_gateway/api_methods/tasks.py  0% smaller
  gateway/sds_gateway/static/js/deprecated/userSearchComponent.js  0% smaller
  gateway/sds_gateway/templates/emails/item_download_error_sdk.html  0% smaller
  gateway/sds_gateway/templates/emails/item_download_error_sdk.txt Unsupported file format
  gateway/sds_gateway/templates/pages/home.html Unsupported file format
  gateway/sds_gateway/templates/users/file_detail.html  0% smaller
  gateway/sds_gateway/templates/users/file_list.html  0% smaller
  gateway/sds_gateway/templates/users/files.html Unsupported file format
  gateway/sds_gateway/templates/users/temporary_zip_download.html  0% smaller
  gateway/sds_gateway/users/tests/test_drf_views.py  0% smaller
  gateway/sds_gateway/users/tests/test_group_sharing.py  0% smaller
  gateway/sds_gateway/users/tests/test_views.py  0% smaller
  gateway/sds_gateway/visualizations/processing/utils.py  0% smaller

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Addresses SFDS-314 by enabling public (unauthenticated) rendering of selected dataset UI/details, while also improving navigation/UI consistency and updating “file-list” → “capture-list” naming across the app.

Changes:

  • Allow unauthenticated access to dataset details for public + FINAL datasets and introduce a template-path safety check for fragment rendering.
  • Rename routes and references from file-list to capture-list, adding legacy redirects to preserve old URLs.
  • UI polish (navbar icons, layout tweaks) + updated/added tests for access control and template rendering security.

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
gateway/sds_gateway/visualizations/processing/utils.py Updates Pydantic config to v2-style ConfigDict to remove deprecation warnings.
gateway/sds_gateway/users/views.py Removes auth requirement for dataset details, adds template path validation helper, and adjusts typing/casts.
gateway/sds_gateway/users/urls.py Introduces capture-list routes and permanent redirects for legacy file-list URLs.
gateway/sds_gateway/users/tests/test_views.py Adds tests for unauth public dataset details access and fragment-rendering security cases.
gateway/sds_gateway/users/tests/test_group_sharing.py Updates reverse() calls to new users:capture_list route name.
gateway/sds_gateway/users/tests/test_drf_views.py Updates reverse() calls to new users:capture_list route name.
gateway/sds_gateway/templates/users/temporary_zip_download.html Updates redirect target from file_list to capture_list.
gateway/sds_gateway/templates/users/files.html Restructures Files page header/actions layout and actions menu.
gateway/sds_gateway/templates/users/file_list.html Adds a horizontal rule for visual consistency.
gateway/sds_gateway/templates/users/file_detail.html Updates “back” link destination to capture_list.
gateway/sds_gateway/templates/pages/home.html Tweaks CTA text for public dataset browsing/downloading.
gateway/sds_gateway/templates/emails/item_download_error_sdk.txt Updates SDK instructions link to capture-list for captures.
gateway/sds_gateway/templates/emails/item_download_error_sdk.html Updates SDK instructions links to capture-list for captures.
gateway/sds_gateway/templates/emails/item_download_error.html Updates retry link to capture-list for captures.
gateway/sds_gateway/templates/base.html Adds icons to navbar items and updates Captures link to capture_list.
gateway/sds_gateway/static/js/deprecated/userSearchComponent.js Updates capture refresh URL to /users/capture-list/.
gateway/sds_gateway/static/css/file-manager.css Minor formatting/comment adjustments and removal of now-unused .files-page-container font rule.
gateway/sds_gateway/api_methods/tasks.py Updates capture item URL to /users/capture-list/ in notifications.
gateway/justfile Ensures down removes orphans and adds a tip related to local image builds.
gateway/config/settings/local.py Enables Django template debug mode in local settings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lucaspar lucaspar requested a review from klpoland February 24, 2026 20:30
@lucaspar lucaspar merged commit 3e06700 into master Feb 25, 2026
2 checks passed
@lucaspar lucaspar deleted the lp/wip branch February 25, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working gateway Gateway component javascript Pull requests that update non-trivial javascript code styling Special focus on styling of front-end components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants