Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Addresses SFDS-314 by enabling public (unauthenticated) rendering of selected dataset UI/details, while also improving navigation/UI consistency and updating “file-list” → “capture-list” naming across the app.
Changes:
- Allow unauthenticated access to dataset details for public + FINAL datasets and introduce a template-path safety check for fragment rendering.
- Rename routes and references from
file-listtocapture-list, adding legacy redirects to preserve old URLs. - UI polish (navbar icons, layout tweaks) + updated/added tests for access control and template rendering security.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| gateway/sds_gateway/visualizations/processing/utils.py | Updates Pydantic config to v2-style ConfigDict to remove deprecation warnings. |
| gateway/sds_gateway/users/views.py | Removes auth requirement for dataset details, adds template path validation helper, and adjusts typing/casts. |
| gateway/sds_gateway/users/urls.py | Introduces capture-list routes and permanent redirects for legacy file-list URLs. |
| gateway/sds_gateway/users/tests/test_views.py | Adds tests for unauth public dataset details access and fragment-rendering security cases. |
| gateway/sds_gateway/users/tests/test_group_sharing.py | Updates reverse() calls to new users:capture_list route name. |
| gateway/sds_gateway/users/tests/test_drf_views.py | Updates reverse() calls to new users:capture_list route name. |
| gateway/sds_gateway/templates/users/temporary_zip_download.html | Updates redirect target from file_list to capture_list. |
| gateway/sds_gateway/templates/users/files.html | Restructures Files page header/actions layout and actions menu. |
| gateway/sds_gateway/templates/users/file_list.html | Adds a horizontal rule for visual consistency. |
| gateway/sds_gateway/templates/users/file_detail.html | Updates “back” link destination to capture_list. |
| gateway/sds_gateway/templates/pages/home.html | Tweaks CTA text for public dataset browsing/downloading. |
| gateway/sds_gateway/templates/emails/item_download_error_sdk.txt | Updates SDK instructions link to capture-list for captures. |
| gateway/sds_gateway/templates/emails/item_download_error_sdk.html | Updates SDK instructions links to capture-list for captures. |
| gateway/sds_gateway/templates/emails/item_download_error.html | Updates retry link to capture-list for captures. |
| gateway/sds_gateway/templates/base.html | Adds icons to navbar items and updates Captures link to capture_list. |
| gateway/sds_gateway/static/js/deprecated/userSearchComponent.js | Updates capture refresh URL to /users/capture-list/. |
| gateway/sds_gateway/static/css/file-manager.css | Minor formatting/comment adjustments and removal of now-unused .files-page-container font rule. |
| gateway/sds_gateway/api_methods/tasks.py | Updates capture item URL to /users/capture-list/ in notifications. |
| gateway/justfile | Ensures down removes orphans and adds a tip related to local image builds. |
| gateway/config/settings/local.py | Enables Django template debug mode in local settings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gateway/sds_gateway/templates/emails/item_download_error_sdk.html
Outdated
Show resolved
Hide resolved
klpoland
reviewed
Feb 25, 2026
klpoland
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SFDS-314
Configclass.local.py.file_listtocapture_listfor consistency and clarity.