QML send change to lightning#10723
Open
accumulator wants to merge 6 commits into
Open
Conversation
…ment as it implicitly closes the dialog. Instead emit `confirmed` signal and let the dialog initiator close the dialog when applicable.
…n finalizer options depending on the use-case
…ackground job is running
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add change-to-lightning option in
ConfirmTxDialog.This builds on the prep work done in #10694
Options available to the user in
ConfirmTxDialogis now aflagon the finalizer, instead of ashowOptionsboolean property on the QML side. Sending change to lightning is disabled for sweeps and channel-opens.