Skip to content

Carry the publish-time journey id on ProposalMetadata - #35

Open
geffrak wants to merge 1 commit into
mainfrom
geffrak/proposal-metadata-journey-id
Open

Carry the publish-time journey id on ProposalMetadata#35
geffrak wants to merge 1 commit into
mainfrom
geffrak/proposal-metadata-journey-id

Conversation

@geffrak

@geffrak geffrak commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Problem

Nothing on the wire says which journey a proposal belongs to, and a client cannot work it out.

ProposalMetadata.proposal_id does not answer it: GetEvents echoes the SHA3-512 of the execution context, while GetProposal overwrites the same field with the flow id. Even given both, reconstruction is impossible in principle - the journey kind depends on what the mint carried (a roll-forward flow, an invitation lobby, or the proposal itself), and the proposal kind is addressed by a hash the client never holds.

Consumers that need to link to a request have been rebuilding the id from whichever id they had, which produces a dead link whenever the guess is wrong.

Fix

Add journey_id to ProposalMetadata, carrying the id the server already stamps at publish time. Field 10, additive.

Validation

buf lint clean. buf breaking against main clean. Go and TS regenerated with bufgen.sh.

Impact

Additive: no existing field changes meaning or number. Consumers can delete their client-side reconstruction once the server populates it.

@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedAug 21, 2026, 12:43 PM

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 295051a4-3532-414f-889f-e5813fc1bf11

📥 Commits

Reviewing files that changed from the base of the PR and between 9cb6a6e and 840adc7.

⛔ Files ignored due to path filters (2)
  • gen/es/proto/splitsecure/proposals/v1/proposal_metadata_pb.ts is excluded by !**/gen/**, !gen/**
  • gen/go/proto/splitsecure/proposals/v1/proposal_metadata.pb.go is excluded by !**/*.pb.go, !**/gen/**, !gen/**
📒 Files selected for processing (1)
  • proto/splitsecure/proposals/v1/proposal_metadata.proto
🚧 Files skipped from review as they are similar to previous changes (1)
  • proto/splitsecure/proposals/v1/proposal_metadata.proto

Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: Check Generated Code

Walkthrough

The ProposalMetadata.journey_id declaration is unchanged. Its documentation is shorter.

Changes

Proposal metadata

Layer / File(s) Summary
Condense journey identifier documentation
proto/splitsecure/proposals/v1/proposal_metadata.proto
Shortens the journey_id documentation without changing the field declaration.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 840ad

This PR adds the publish-time journey ID without changing existing fields or their meanings; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the ambiguity in proposal identifiers and the additive journey_id field that resolves it.
Title check ✅ Passed The title clearly identifies the main change: carrying the publish-time journey ID in ProposalMetadata.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Buf (1.72.0)
proto/splitsecure/proposals/v1/proposal_metadata.proto

fatal: unable to access 'https://github.com/splitsecure/apis.git/': Failed to connect to github.com port 443 via 127.0.0.1 after 0 ms: Could not connect to server
fatal: could not fetch efef4d054d9a4b865c3456eda7c9778ef35f9c28 from promisor remote


Comment @coderabbitai help to get the list of available commands.

@geffrak
geffrak force-pushed the geffrak/proposal-metadata-journey-id branch from 840adc7 to b314784 Compare August 21, 2026 12:43
@geffrak
geffrak requested a review from Konyaka1 August 21, 2026 15:21
@geffrak
geffrak marked this pull request as ready for review August 21, 2026 15:21
@geffrak
geffrak enabled auto-merge (squash) August 21, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant