Skip to content

Feat/mcp authentication#3065

Open
Kawron wants to merge 22 commits into
feat/mcp-feature-branchfrom
feat/mcp-authentication
Open

Feat/mcp authentication#3065
Kawron wants to merge 22 commits into
feat/mcp-feature-branchfrom
feat/mcp-authentication

Conversation

@Kawron
Copy link
Copy Markdown
Collaborator

@Kawron Kawron commented May 13, 2026

This PR implements support for TLS and token based authentication for both SC4S API and MCP Server.

Both aps have different implementation though they are quite simillar. So I recommend reviewing first package/sbin and then mcp_server folders. I decided not to write a single fit all implementation because:

  1. Those are two different aps, that can are independent of each other and can are deployed separately. If we would like to have shared implementation they would have to import each other
  2. The are small differences between those two, e.g. mcp server token authentication extends FastMcp class for authentication and they use two different web servers: uvicorn vs gunicorn
  3. Keeping implementation seperate give us more flexibility
  4. It should be fairly easy to extract some of the methods to common util package that will be imported by both aps, if the cost of maintaince increases

@Kawron Kawron force-pushed the feat/mcp-authentication branch from e65dd03 to 836b382 Compare May 13, 2026 11:47
@Kawron Kawron marked this pull request as ready for review May 13, 2026 12:13
@Kawron Kawron requested a review from rjha-splunk as a code owner May 13, 2026 12:13
@Kawron Kawron requested a review from sbylica-splunk May 13, 2026 12:14
@Kawron Kawron assigned ajasnosz and unassigned ajasnosz May 13, 2026
@Kawron Kawron requested review from ajasnosz and digrajpu May 13, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants