Skip to content

fix: resolve install.sh mount point before copying Spool.app #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doodlewind merged 1 commit into from
Apr 3, 2026
Merged

fix: resolve install.sh mount point before copying Spool.app #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/landing/public/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ curl -fSL --progress-bar "$DOWNLOAD_URL" -o "$DMG_PATH"

# ── Mount & copy ──
info "Installing to ${INSTALL_DIR}..."
MOUNT_POINT=$(hdiutil attach "$DMG_PATH" -nobrowse -quiet | tail -1 | sed 's/.* //')
MOUNT_POINT=$(hdiutil attach "$DMG_PATH" -nobrowse | tail -1 | sed 's/.* //')
[[ -n "$MOUNT_POINT" ]] || err "Failed to resolve mount point."
[[ -d "${MOUNT_POINT}/${APP_NAME}" ]] || err "Mounted DMG does not contain ${APP_NAME}."

# Remove old version if exists
if [[ -d "${INSTALL_DIR}/${APP_NAME}" ]]; then
Expand All @@ -47,7 +49,7 @@ fi
cp -R "${MOUNT_POINT}/${APP_NAME}" "${INSTALL_DIR}/"

# Unmount
hdiutil detach "$MOUNT_POINT" -quiet 2>/dev/null || true
hdiutil detach "$MOUNT_POINT" >/dev/null 2>&1 || true

# ── Cleanup ──
rm -rf "$TMPDIR_INSTALL"
Expand Down
Loading