Add inline session find and session-to-search handoff#48
Draft
doodlewind wants to merge 1 commit intomainfrom
Draft
Add inline session find and session-to-search handoff#48doodlewind wants to merge 1 commit intomainfrom
doodlewind wants to merge 1 commit intomainfrom
Conversation
Session detail now supports running a new top-bar search, opening an inline find bar with desktop shortcuts, and navigating matches inside message content with the same accent styling used elsewhere in search. The target-message jump remains, but the temporary orange fade was removed to keep the transition visually calm. Constraint: Session-local match styling needed to be fully controllable in the renderer Rejected: Electron webContents.findInPage | could not deliver the desired inline styling and interaction polish Confidence: high Scope-risk: moderate Directive: Keep session find shortcuts scoped to the session detail view so they do not collide with global search interactions Tested: electron-vite build; Playwright fast-search spec (9 tests) Not-tested: Full app TypeScript check remains blocked by unrelated existing repository errors Related: #42
Contributor
|
@doodlewind hi! thanks for fixing the e2e tests file, i have reviewed this and it's good to go, thanks again! ⚡️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased version of #43 (by @chumyin) onto current main, with conflicts resolved.
Summary
Cmd/Ctrl+FplusCmd/Ctrl+ArrowLeft/ArrowRightnavigationConflict resolution (vs #43)
fast-search.spec.ts— kept both main's codex resume test and PR's new session find testsSupersedes #43. Closes #42.
🤖 Generated with Claude Code