Resolve IdClass exception for mapped superclasses with mixed access types.#4252
Open
myleshk wants to merge 1 commit into
Open
Resolve IdClass exception for mapped superclasses with mixed access types.#4252myleshk wants to merge 1 commit into
myleshk wants to merge 1 commit into
Conversation
…ypes. When an @entity uses @access(FIELD) and extends a @MappedSuperclass that uses @access(PROPERTY) with @id on a getter, getSingularAttributes() may not include the inherited @id attribute. Added a fallback in findAttributes() that calls source.getId() to resolve the attribute through the type hierarchy when the for-loop over getSingularAttributes() doesn't find the @id. Closes spring-projects#4246 Signed-off-by: Myles Fang <i@myles.hk>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an @entity uses @access(FIELD) and extends a @MappedSuperclass that uses @access(PROPERTY) with @id on a getter, getSingularAttributes() may not include the inherited @id attribute.
Added a fallback in findAttributes() that calls source.getId() to resolve the attribute through the type hierarchy when the for-loop over getSingularAttributes() doesn't find the @id.
Closes #4246