Fix DuckDB :: casting warning#1284
Merged
Merged
Conversation
DuckDB natively supports PostgreSQL's :: casting shorthand: https://duckdb.org/docs/stable/sql/expressions/cast#explicit-casting Added SupportedDatabase::Duckdb to the allow-list to prevent unnecessary warning and CAST transformation. Fixes sqlpage#1200
lovasoa
approved these changes
May 12, 2026
Collaborator
lovasoa
left a comment
lovasoa
left a comment
There was a problem hiding this comment.
Thanks you for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DuckDB natively supports PostgreSQL's
::casting shorthand (docs), but SQLPage was warning users and transforming it toCAST().This adds
SupportedDatabase::Duckdbto the allow-list alongside Postgres, Snowflake, and Generic to prevent the unnecessary warning and transformation.Fixes #1200