[core] clang-format the include order + fix resulting build breaks#606
Merged
ivmaykov merged 1 commit intosquare:masterfrom May 13, 2023
Merged
[core] clang-format the include order + fix resulting build breaks#606ivmaykov merged 1 commit intosquare:masterfrom
ivmaykov merged 1 commit intosquare:masterfrom
Conversation
Auto-format the include sections of all files using clang-format. Fix the resulting build breaks by adding missing includes. This makes the build less fragile as compilation success doesn't depend as much on include order. We're not all the way there since this isn't a full "IWYU" (include what you use) pass. But, it's a start.
Collaborator
|
What was the command used for this? |
oreparaz
approved these changes
May 13, 2023
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-format the include sections of all files using clang-format. Fix the resulting build breaks by adding missing includes. This makes the build less fragile as compilation success doesn't depend as much on include order.
We're not all the way there since this isn't a full "IWYU" (include what you use) pass. But, it's a start.