Adds tests against the wycheproof test vectors#630
Conversation
442bb1f to
a899629
Compare
oreparaz
left a comment
There was a problem hiding this comment.
LGTM. The 3 test cases we skip sound reasonable to me.
Can you please put a comment here with:
- old binary size
- new binary size
- difference in kB
Thanks!
oreparaz
left a comment
There was a problem hiding this comment.
LGTM. The 3 test cases we skip sound reasonable to me.
Can you please put a comment here with:
- old binary size
- new binary size
- difference in kB
Thanks!
|
It looks like the subzero core binary failed to start in the background in the SignTx regression test action. Hard to tell what's going on, we probably need to improve the logic in the action so it's easier to get logs output. Did you run it locally with ASAN + UBSAN without any issues? |
a899629 to
81a3d9b
Compare
Ran locally with Added sleeps in the CI script and the tests execute successfully which confirms the theory. |
Old binary size: 546916 bytes |
|
Approving with some nits, please fix them before merging. |
ivmaykov
left a comment
There was a problem hiding this comment.
Actually approving this time.
Along the same spirit as the secp256k1 PR 1245. This tests against all 463 vectors but includes exclusions for 3 of them. Comments include the details outlining why each was excluded. The json and c code was generated using the included python code (utils/tests_wycheproof_generate.py).
642c433 to
069a863
Compare
Along the same spirit as the secp256k1 PR 1245. This tests against all 463 vectors but includes exclusions for 3 of them. Comments include the details outlining why each was excluded.
The json and c code was generated using the included python code (utils/tests_wycheproof_generate.py).
We decided not to duplicate this generation code for now.