Open
Conversation
Add support for ACME Renewal Information (ARI) to getssl. If we are past the start window for certificate renewal add the certificate identifier to the new order request.
Author
|
I've tested this with a certificate that had passed the ARI window, and it worked fine. Unfortunately it wasn't WITHIN the ARI window (because it was in the middle of the night and I couldn't stay up that late on that day), but I checked the boulder source code and boulder will reject a order with a invalid "replaces" element so I feel confident that it is at least well-formed. I'll try doing a renewal within the ARI window later this week. Again, any feedback welcome; I'd like to get this merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a patch implementing ARI (RFC9773) support for
getssl. I will admit that I haven't actually tested it yet with a certificate within the ARI renewal window; the shortlived certificate I got will enter the renewal window tomorrow so I will test it then, but I wanted to get some preliminary feedback regarding style, any suggestions for code changes, etc etc. I took a guess at the busybox support for thedatecommand. I am not convinced the logic about using ARI support when you also set RENEW_ALLOW is correct; I welcome any improvements there.As a side note I saw that profile support was added (yay!) but I am not convinced that you are supposed to pick the first profile in the list provided by the server if the client doesn't specify one. My reading of the I-D is that if you want to take the 'default' you should omit the profile completely and let the server decide. It's entirely possible I am wrong.