Ensure the subdevice range properties require their parent#2
Open
peternewman wants to merge 1 commit into
Open
Ensure the subdevice range properties require their parent#2peternewman wants to merge 1 commit into
peternewman wants to merge 1 commit into
Conversation
Even if they're optional, when they are used they should require what they are ranging
Owner
|
If someone wants to write a schema with "get_request_subdevice_range" and "set_request_subdevice_range", but without corresponding "get_request" and "set_request", that's up to them. These are fields that effectively annotate "get_request" and "set_request", so their presence shouldn't require them. They will do nothing. It's not the schema's job to detect badly-formed schema instances. That's a job for a linter tool. |
Owner
|
Another way of putting it: My principle here is that annotations shouldn't require the thing they're annotating, at least in the schema validation level. |
3e6d0c1 to
ac42033
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even if they're optional, when they are used they should require what they are ranging