Further validation#8
Conversation
…ive.yml Put the file in the right place
…/validate-alternative.ym Now in the right place!
Install the right one
ssilverman
left a comment
There was a problem hiding this comment.
Actually, @peternewman could you combine all the commits into one and force push?
|
I could, or you could just use the Squash and Merge option, which is probably less effort all round: You might need to enable it first: |
|
Is the Squash and Merge option acceptable @ssilverman or do you want me to have a go from my end? |
|
I'm familiar with squash merges, I just wanted to give you an opportunity to create your own commit message. If you don't want to, I'll just create a commit and give you credit in the comments. |
|
See: #6 (comment) |
I thought I'd replied before, but seemingly not. It strikes me the squash within GitHub's UI is probably the best option, you get to specify the commit message, which means you can standardise them and keep them consistent between contributors, where the GitHub squash will retain my authorship of all the commits in blame etc (as opposed to just a comment in a commit message). Otherwise if you'd like to propose a commit message, I can do the squash in another branch and open yet another PR if you really don't want to use GitHub's squash UI yourself? "Add jsonlint GitHub Action for automatic JSON validation"? |
3e6d0c1 to
ac42033
Compare
This extends the validation in #6 by actually validating against our schema.