-
Notifications
You must be signed in to change notification settings - Fork 1
Remove Bertie from org #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @sjpb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the organization's GitHub access management by removing a specific user, 'bertiethorpe', from the Terraform-managed configuration. This ensures that the infrastructure-as-code accurately reflects current team membership and access permissions, maintaining security and operational hygiene. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes the user 'bertiethorpe' from the 'Batch' and 'Developers' teams. The changes in terraform.tfvars.json are correct and follow the existing convention of keeping member lists sorted alphabetically.
An observation from reviewing the broader context: the project documentation suggests that removing a team member requires manual terraform state rm commands. However, the github_team_membership Terraform resource does not have prevent_destroy enabled, which means Terraform should handle the removal automatically. You may want to consider updating the documentation to reflect this, to simplify the process for future off-boarding.
The change itself is ready to be merged.
Terraform Format and Style 🖌
|
|
🫡 |
No description provided.