chore: remove unused UpstreamGroup type#107
Merged
Merged
Conversation
The UpstreamData.Groups field and UpstreamGroup struct were never populated or consumed — converters only wrote an empty slice and the ToolHive Registry.Groups (which is unrelated and still in use) covers the grouping concept internally. Drop the unused type, the schema groups property, and the dependent validator branch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ChrisJBurns
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpstreamData.Groupsfield and theUpstreamGroupstruct fromregistry/types/upstream_registry.go. These were tagged "optional, for future use" and never populated or consumed — converters only wrote an empty slice.groupsblock fromregistry/types/data/upstream-registry.schema.jsonand thevalidateGroupServersbranch from the schema validator.Registry.Groups/Grouptype inregistry/types/registry_types.go(actively used viaGetAllGroups,GetGroupByName,GetAllGroupServers) is untouched.Net diff: 8 insertions, 282 deletions across 6 files.
Downstream follow-ups
After this merges, two empty-slice literals in
toolhive-registry-serverneed to be dropped (no behavior change):internal/registry/testutils_upstream.go:28internal/sources/api_upstream.go:201No usages in
toolhiveordockyard.Test plan
task lint— registry packages clean (0 issues)task test—registry/typesandregistry/converterspass with-racetoolhive-registry-serverbuild picks up the type removal cleanly when bumped🤖 Generated with Claude Code