-
Notifications
You must be signed in to change notification settings - Fork 0
ROX-31487: Add helm chart #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
=======================================
Coverage 77.36% 77.36%
=======================================
Files 26 26
Lines 1109 1109
=======================================
Hits 858 858
Misses 216 216
Partials 35 35 ☔ View full report in Codecov by Sentry. |
bf4c024 to
978b646
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
978b646 to
9917dce
Compare
9917dce to
41440c8
Compare
| @@ -0,0 +1,12 @@ | |||
| {{- if and (eq .Values.config.central.authType "static") (not .Values.config.central.existingSecret.name) }} | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this should be exposed in helm. Static is fine for testing but for real deployment I think we should promote m2m Auth if mcp needs to be authenticated. On the other hand I could imagine it could be useful but its should be noted what are the consequences.
|
|
||
| # Configuration management tools | ||
| configManager: | ||
| enabled: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it should be true so an example is working out of the box
Description
This PR is adding helm chart from StackRox MCP server
Additional changes:
TODO
Validation
An example command to deploy helm: