Delete operator CRs in teardown #79
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viswajithiii
approved these changes
Oct 20, 2021
| # Delete operator CRs. This is broken out into a separate invocation, as the entire command fails | ||
| # if the CRDs are not available | ||
| kubectl -n stackrox get central.platform.stackrox.io,securedcluster.platform.stackrox.io -o name 2>/dev/null || true | ||
| } | xargs kubectl -n stackrox delete --wait |
Contributor
There was a problem hiding this comment.
I think a CRD can't be cleanup if the operator does not run and a Central/SecuredCluster instance is tried to be deleted.
At least I failed on this the last time I wanted to add it to the teardown script.
Contributor
Author
There was a problem hiding this comment.
Oh, because of the finalizer? We can solve this via force deletion, but good catch
Contributor
There was a problem hiding this comment.
Which finalizer do you mean?
I had the assumption that the CR can't be deleted because the operator executes the deletion. Therefore if the operator is running the CR can't be deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.