feat: add clusterrole/binding support in the chart#421
Open
rasta-rocket wants to merge 5 commits intostakater:mainfrom
Open
feat: add clusterrole/binding support in the chart#421rasta-rocket wants to merge 5 commits intostakater:mainfrom
rasta-rocket wants to merge 5 commits intostakater:mainfrom
Conversation
aslafy-z
requested changes
Jul 24, 2025
rasta-rocket
force-pushed
the
clusterrole
branch
from
eb5363b to
00bb8e2
Compare
aslafy-z
requested review from
rasheedamir
and removed request for
karl-johan-grahn
aslafy-z
force-pushed
the
clusterrole
branch
from
a6cef79 to
ffc8416
Compare
aslafy-z
requested changes
Sep 13, 2025
Collaborator
aslafy-z
left a comment
aslafy-z
left a comment
There was a problem hiding this comment.
Thank you @rasta-rocket for your contribution, sorry that it made so much time to process.
I went ahead and made some cosmetic changes to the Role and ClusterRole values descriptions, and also aligned the ClusterRole and ClusterRoleBinding templates with the existing Role and RoleBinding ones.
Can you please add the associated tests for ClusterRole and ClusterRoleBinding? You can use the existing Role and RoleBinding ones as a base. 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey folks 👋
Small PR to add the support of clusterrole/binding.
Pretty useful if you need to deploy a software that need to discuss with the kubernetes API
Don't hesitate to reach me if any question 😉
Cheers ☀️