Skip to content

deployment: wrap cdk8s requirements in docker container#12335

Merged
idan-starkware merged 2 commits intomain-v0.14.1-committerfrom
idan/main-v0.14.1-committer/02-02-2026_cdk8s_setup_in_docker
Feb 12, 2026
Merged

deployment: wrap cdk8s requirements in docker container#12335
idan-starkware merged 2 commits intomain-v0.14.1-committerfrom
idan/main-v0.14.1-committer/02-02-2026_cdk8s_setup_in_docker

Conversation

@idan-starkware
Copy link
Copy Markdown
Contributor

@idan-starkware idan-starkware commented Feb 5, 2026

Note

Medium Risk
Build/entrypoint scripts run as root during image build/startup and install multiple external tools, so failures or misconfiguration could impact developer environments and CI if adopted. No runtime application logic changes; the primary risk is in developer tooling and container security posture (sudoers, kubeconfig handling).

Overview
Adds a containerized workflow for deployments/sequencer so contributors can run cdk8s synth without installing Python/Node/pipenv/kubectl locally. This introduces a Docker image build (local/Dockerfile + dependencies.sh) that installs required tooling (including gcloud/kubectx) and a wrapper script local/run-in-docker.sh that builds/runs the container with the repo mounted.

The container entrypoint (docker-entrypoint.sh) creates a user matching host UID/GID, mounts host kubeconfig read-only then copies it to a writable location, enables passwordless sudo, and auto-runs setup.sh to perform pipenv install + cdk8s import when needed. Documentation in deployments/sequencer/README.md is reorganized/expanded to cover both manual and Docker-based setup and provide clearer usage/config references.

Written by Cursor Bugbot for commit 11ff01f. This will update automatically on new commits. Configure here.

@idan-starkware idan-starkware self-assigned this Feb 5, 2026
@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@idan-starkware idan-starkware force-pushed the idan/main-v0.14.1-committer/02-02-2026_cdk8s_setup_in_docker branch from e496506 to d00040d Compare February 8, 2026 10:13
Comment thread deployments/sequencer/local/dependencies.sh
@idan-starkware idan-starkware force-pushed the idan/main-v0.14.1-committer/02-02-2026_cdk8s_setup_in_docker branch from d00040d to 568266b Compare February 8, 2026 10:56
Comment thread deployments/sequencer/local/docker-entrypoint.sh
Comment thread deployments/sequencer/local/dependencies.sh
Comment thread deployments/sequencer/local/.dockerignore
@idan-starkware idan-starkware force-pushed the idan/main-v0.14.1-committer/02-02-2026_cdk8s_setup_in_docker branch from 568266b to f1b4b56 Compare February 8, 2026 11:17
Comment thread deployments/sequencer/local/dependencies.sh
Comment thread deployments/sequencer/local/run-in-docker.sh
@idan-starkware idan-starkware force-pushed the idan/main-v0.14.1-committer/02-02-2026_cdk8s_setup_in_docker branch 2 times, most recently from 351180f to 8f05458 Compare February 8, 2026 13:30
@idan-starkware idan-starkware force-pushed the idan/main-v0.14.1-committer/02-02-2026_cdk8s_setup_in_docker branch from 8f05458 to 11ff01f Compare February 8, 2026 13:37
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Comment thread deployments/sequencer/local/dependencies.sh
Copy link
Copy Markdown
Contributor Author

@idan-starkware idan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idan-starkware reviewed 10 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @idan-starkware).

@idan-starkware idan-starkware added this pull request to the merge queue Feb 12, 2026
Merged via the queue into main-v0.14.1-committer with commit 3b2e7cf Feb 12, 2026
17 of 24 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants