Add Neuralwatt provider#1760
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 1, 2026, 12:41 PM ET / 16:41 UTC. Summary Reproducibility: not applicable. this is a new provider feature rather than a bug report. Source inspection and mock tests cover the intended paths, but exact-head live Neuralwatt behavior is not proven. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land only after redacted exact-head live proof and maintainer acceptance of balance-only semantics, or update the provider to show active subscription kWh alongside prepaid balance. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a new provider feature rather than a bug report. Source inspection and mock tests cover the intended paths, but exact-head live Neuralwatt behavior is not proven. Is this the best way to solve the issue? Unclear until maintainer product acceptance. The implementation follows existing provider patterns, but balance-only display versus subscription-kWh display remains a product contract choice. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 101c17801949. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dbab6f7a73
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dbab6f7 to
152081f
Compare
152081f to
31ebe87
Compare
|
@clawsweeper re-review Added redacted runtime proof from a live Neuralwatt CLI fetch to the PR body, and addressed the inline review feedback. Current head: 31ebe87. |
|
🦞🧹 I asked ClawSweeper to review this item again. |
7ead310 to
fb5e47f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb5e47fb3b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fb5e47f to
38b564c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 38b564c39c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
38b564c to
a2e3377
Compare
Summary
CodexBar can now query Neuralwatt's official
GET /v1/quotaendpoint with API-key authentication and render prepaid USD credit balance. The provider is wired through settings, config/environment resolution, managed token accounts, CLI, widgets, and provider documentation.Maintainer audit
Exact head:
b00c39edfRebased onto current
mainat129f6962e; contributor authorship remains preserved in1e0e869fc.Maintainer hardening on top of the contributor branch:
NEURALWATT_API_KEYin diagnostics and hides the unsupported generic Spend lane;Provider isolation audit: Neuralwatt identity, plan, and usage fields come only from the Neuralwatt response. API-key resolution is provider-scoped. No browser-cookie or keychain path is added.
Official contract and product decision
Neuralwatt's quota API documentation confirms that prepaid credit balance and an active subscription's kWh allowance are separate quota pools. It also notes that lifetime USD cost can exceed prepaid credits because subscription usage is billed separately.
This branch deliberately keeps the contributor's balance-only product semantics. That is the smallest UI change, but it can show
$0/ exhausted while an active subscription still has usable kWh. Surfacing both pools is more accurate for subscription users, at the cost of adding a second unit and quota window to the menu model. Recommendation: do not merge until we surface active subscription allowance alongside prepaid credits, or explicitly accept balance-only semantics as the product contract.Runtime proof
The contributor supplied redacted live CLI output from the original branch, confirming the endpoint/auth path. No authorized Neuralwatt credential is available in the maintainer environment, so the rebased exact head could not be independently exercised live. The original proof therefore remains useful but is not exact-head proof.
Validation
make check: passed;make test: 44/44 shards passed;./Scripts/package_app.sh: passed and producedCodexBar.app;git diff --check origin/main...HEAD: passed;Integration state
The branch is mergeable against current
main, including the landed cost-scanner changes from #1797 and the subsequent widget fix. Unrelated behind drift is intentionally preserved; rebase only if a real conflict or semantic overlap appears. Exact local proof is complete, while CI remains intentionally canceled pending the product/live-proof decision. No changelog entry is included on the contributor branch; the maintainer should add one with contributor thanks if the product decision is resolved and the PR is landed.