Make weekly usage parsing optional for OpenCode Go#1788
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 1, 2026, 12:23 PM ET / 16:23 UTC. Summary Reproducibility: yes. By source inspection, current main requires weeklyUsage percent/reset fields before returning an OpenCode Go snapshot, and the PR adds rolling-only Seroval and JSON fixtures for that exact failure shape. Review metrics: 3 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Merge the focused parser/snapshot fix after required checks pass, while leaving OpenCode Go multi-workspace behavior to the separate product discussion. Do we have a high-confidence way to reproduce the issue? Yes. By source inspection, current main requires weeklyUsage percent/reset fields before returning an OpenCode Go snapshot, and the PR adds rolling-only Seroval and JSON fixtures for that exact failure shape. Is this the best way to solve the issue? Yes. Making weekly usage optional while keeping rolling usage required and preserving hasWeeklyUsage through snapshot projection is the narrowest maintainable fix; multi-workspace behavior remains separate product work. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 101c17801949. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
6e717f0 to
37bbcb2
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
d3381a0 to
ef7196c
Compare
|
Maintainer proof decision: fixture-only evidence is accepted for this bounded parser change; live browser/Keychain probing is intentionally excluded by repository safety policy. Exact-head focused tests, source-blind compiled-artifact validation, @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
ef7196c to
f4a1879
Compare
Co-authored-by: Moe Kanan <mohammedkanan1997@gmail.com>
f4a1879 to
0045897
Compare
|
Exact-head proof refreshed after the final rebase onto merged #1692.
Maintainer acceptance remains fixture-only for this bounded parser repair. No live OpenCode account, browser-cookie import, or Keychain prompt was used. @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
OpenCode Go recently changed its dashboard response and can omit the weekly usage window. CodexBar then rejected an otherwise valid rolling window and fell back to Zen balance.
What changed
Proof
0045897835c55ece328222af7d3c2e90d3ad094d, based onorigin/mainat101c178019491d9e9310b3b51a5e0e9b85b359ab.origin/mainwithparseFailed("Missing usage fields.").swift test --filter OpenCodeGo— 63/63 passing across 6 suites.make check— passing, zero SwiftLint violations.swift test --skip-build --filter OpenCodeGoUsageParserTests) — 27/27 passing, including Seroval and JSON rolling-only cases, nested weekly recovery, and missing-required-field rejection.make test— all 44 shards passing on the exact reviewed head../Scripts/package_app.sh— release build, widget extension, assembly, and local signing passed; exact-headCodexBar.appcreated without launching it.gpt-5.5, high reasoning) — clean, no accepted/actionable findings (0.86).Fixtures cover both seroval and JSON dashboard shapes. Maintainer decision: fixture-only proof is accepted for this bounded parser change. A live account/browser-cookie/Keychain probe was intentionally not run because repository policy requires safe parser fixtures when behavior can be verified without prompting for secrets.