Guard repository size and document history cleanup#1858
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 3, 2026, 11:18 PM ET / 03:18 UTC. Summary Reproducibility: not applicable. this is a repository tooling and documentation cleanup, not a runtime bug report. The relevant behavior is source-verifiable from the proposed scripts and current tracked-tree checks. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the guard and documentation if maintainers accept the repository-size policy, while keeping any actual history rewrite as a separate coordinated maintainer operation. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a repository tooling and documentation cleanup, not a runtime bug report. The relevant behavior is source-verifiable from the proposed scripts and current tracked-tree checks. Is this the best way to solve the issue? Yes, if maintainers accept the policy threshold: the implementation uses the existing lint/check path, tests the guard in a temporary repository, and clearly separates prevention from any maintainer-only history rewrite. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against a9e47e78c11b. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
The hardened follow-up landed in #1875 as f6732bd. It preserves this PR's intent while validating immutable staged blob OIDs from the Git index, covering empty indexes, submodules, symlinks, staged-vs-working-tree divergence, exact size boundaries, newline paths, and the full release-artifact matrix. Contributor credit is preserved in the changelog and squash commit. Thanks @joeVenner! |
Summary
.app,.dSYM,.xcarchive,.xcresult,.ipa,.zip,.delta,.dmg,.pkg,.tar.gz, and.tgzpathscodexbar.pngand point the README atdocs/codexbar.pngRegression proof
Scripts/test_repository_size.shverifies that:Validation
./Scripts/check_repository_size.sh— passes across 1,609 tracked entries./Scripts/test_repository_size.sh— passesmake check— passes (144 documentation links, zero SwiftFormat changes, zero SwiftLint violations)Risk
Low. The guard is lint-only and operates on Git's tracked-file index. The main compatibility risk is intentionally blocking future large binaries or packaged artifacts; the documentation explains how to keep generated outputs outside version control.