Skip to content

Update default build type for local development#2676

Merged
leofelix077 merged 3 commits intomasterfrom
fix/default-build-type-local-dev-amplitude
Apr 3, 2026
Merged

Update default build type for local development#2676
leofelix077 merged 3 commits intomasterfrom
fix/default-build-type-local-dev-amplitude

Conversation

@leofelix077
Copy link
Copy Markdown
Collaborator

Screenshot 2026-04-03 at 11 25 01 Screenshot 2026-04-03 at 11 27 19

@leofelix077 leofelix077 requested a review from CassioMG April 3, 2026 14:28
@leofelix077 leofelix077 self-assigned this Apr 3, 2026
@leofelix077 leofelix077 added the bug Something isn't working label Apr 3, 2026
Copilot AI review requested due to automatic review settings April 3, 2026 14:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the extension’s webpack configuration so local builds default to a "development" build type (instead of implicitly behaving like "production" when BUILD_TYPE isn’t provided), aligning analytics/remote-config “channel” behavior with local development workflows.

Changes:

  • Default BUILD_TYPE to "development" in webpack.common.js (including the DefinePlugin fallback).
  • Explicitly define BUILD_TYPE as "development" in the dev-server webpack config.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
extension/webpack.dev.js Adds a dev-server DefinePlugin value for BUILD_TYPE.
extension/webpack.common.js Changes default/fallback BUILD_TYPE from "production" to "development".

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@piyalbasu piyalbasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the 2 copilot comments. But otherwise lgtm!

leofelix077 and others added 2 commits April 3, 2026 12:58
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@leofelix077 leofelix077 merged commit cb98d83 into master Apr 3, 2026
9 checks passed
@leofelix077 leofelix077 deleted the fix/default-build-type-local-dev-amplitude branch April 3, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants