Propagate --hd-path to auth signers and alias resolution.#2437
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures the CLI’s --hd-path option is applied consistently when resolving account aliases and when constructing signers for Soroban auth, so derived addresses/signatures come from the same HD index across the flow.
Changes:
- Thread
hd_path: Option<usize>throughUnresolvedScAddress::resolveso account alias resolution derives the correct address for the selected HD path. - Use
config.hd_path()when building signers (source signer + auth signer resolution) instead of always defaulting to path 0. - Add an integration test asserting
--hd-pathaffects both--addralias resolution and auth signing.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/soroban-cli/src/config/sc_address.rs | Adds hd_path parameter to address/alias resolution and uses it when deriving the account ID from an identity key. |
| cmd/soroban-cli/src/config/mod.rs | Propagates --hd-path into source_signer() so source auth signing uses the selected HD path. |
| cmd/soroban-cli/src/commands/contract/arg_parsing.rs | Propagates --hd-path into --addr resolution and auth signer derivation. |
| cmd/crates/soroban-test/tests/it/integration/hello_world.rs | Adds an integration test covering --hd-path propagation for auth invocation with --addr alias. |
leighmcculloch
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Propate the HD path, so auth signers and alias resolution is consistent all around.
Why
https://stellarfoundation.slack.com/archives/C06GHH10005/p1772940381744689
Known limitations
N/A